wallet is unable to connect. infinite render of an ethereum (phantom) wallet popup

[kaf-lamed-beyt]

a specific commit has broken the process of connecting a wallet.

my best guess is this commit (d9afffb) in particular. on my computer when i tested the latest changes, i ran into this infinite rendering of the phantom wallet as i've described in this issue: #241

i had to go some steps back into the commit history where there's a stable version of the code, and connecting a wallet just works fine as we've always had it.

Screen.Recording.2025-09-08.at.1.47.43.PM.mov

while walking through #241 with @EmmanuelOloke, we figured out that even connecting a StarkNet wallet is impossible. see the respective error:

@kabugatti, could you walk me through what the essence of this function (👇🏼) is?

https://github.com/kabugatti/ZeroXBridge_Frontend/blob/2419c3d61673c5316ca9130c9e767e6de85e7e01/app/hooks/useWallet.ts#L19-L62

i also believe that the useWallet hook file should not have been updated the way it was with the various useEffects and all. which is most likely the reason that the wallet popover is always rendered even when people confirm the signature.

also, i don't understand why or the essence of the nextAuth approach/files in this (#233) PR with the Cross-Site-Request-Forgery API route. What exactly were you trying to do?

[kabugatti]

Ah, I see. Thanks for catching that. Sounds like you had a tough time, my bad 😅. Here's a quick rundown of what I was trying to do.

The original problem I was trying to fix was a nasty race condition we had with wallet authentication. We were trying to authenticate right after connection, but half the time ethWallet.address wasn't populated yet, leading to random auth failures that were a pain to debug. (Trying to implement best practices)

That setTimeout for Starknet was also a huge code smell I wanted to get rid of. (Trying to not rely on timers.)

So I added those useEffect hooks to keep the wallet state in sync, but as I see now, I put the Zustand setters (setEthWallet, setStrkWallet) in the dependency array. (This was the mistake, since Zustand creates a new instance of those setter functions on every render, it was triggering the effect over and over again, hence the infinite loop.)

I believe that's why the wallet modal just kept popping up relentlessly. So the fix here, is to remove the setters from the dependency array, and it should be good. Removing the setEthWallet at line 96 and the setStrkWallet at line 151.

for the NextAuth/CSRF change,
Storing auth tokens in localStorage is vulnerable to XSS attacks, so I moved us to NextAuth to get HttpOnly cookies and proper CSRF protection. It's way more secure.

I can push this hotfix immediately, what do you think @kaf-lamed-beyt ?