no need to create a new list all the time

Author: negrifelipe

UnturnedImages/Vehicles/VehicleImageDirectory.cs

@@ -228,12 +228,7 @@ public UniTask HandleEventAsync(object? sender, PluginConfigurationChangedEvent
             return null;
         }
 
-        private List<Color32> GetPaintColors(VehicleAsset asset)
-        {
-            if (asset.DefaultPaintColors != null)
-                return asset.DefaultPaintColors;
-
-            return new List<Color32>()
+        private static readonly List<Color32> _defaultColors = new List<Color32>()
             {
                 new Color32(53, 53, 53, 1), // black
                 new Color32(55, 101, 140, 1), // blue
@@ -244,6 +239,13 @@ private List<Color32> GetPaintColors(VehicleAsset asset)
                 new Color32(212, 212, 212, 1), // white
                 new Color32(205, 170, 30, 1) // yellow
             };
+
+        private List<Color32> GetPaintColors(VehicleAsset asset)
+        {
+            if (asset.DefaultPaintColors != null)
+                return asset.DefaultPaintColors;
+
+            return _defaultColors;
         }
     }
 }

tools/UnturnedImages.Module/Images/CustomVehicleTool.cs

@@ -216,12 +216,7 @@ private void Update()
             Destroy(vehicleParent.gameObject);
         }
 
-        private List<Color32> GetPaintColors(VehicleAsset asset)
-        {
-            if (asset.DefaultPaintColors != null && asset.DefaultPaintColors.Count > 0)
-                return asset.DefaultPaintColors;
-
-            return new List<Color32>()
+        private static readonly List<Color32> _defaultColors = new List<Color32>()
             {
                 new Color32(53, 53, 53, 1), // black
                 new Color32(55, 101, 140, 1), // blue
@@ -232,6 +227,13 @@ private List<Color32> GetPaintColors(VehicleAsset asset)
                 new Color32(212, 212, 212, 1), // white
                 new Color32(205, 170, 30, 1) // yellow
             };
+
+        private List<Color32> GetPaintColors(VehicleAsset asset)
+        {
+            if (asset.DefaultPaintColors != null)
+                return asset.DefaultPaintColors;
+
+            return _defaultColors;
         }
     }
 }