Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepCounter logic with multiple calls to Simulate() #410

Closed
ptheywood opened this issue Oct 22, 2020 · 2 comments
Closed

StepCounter logic with multiple calls to Simulate() #410

ptheywood opened this issue Oct 22, 2020 · 2 comments

Comments

@ptheywood
Copy link
Member

If a second call is made to simulate() without a call to reset() what should happen?

I.e. if the simulation config says a simulation is 4 steps, simulate will execute steps 0, 1, 2, 3. A subsequent call to simulate will run steps 4, 5, 6, 7.

Should this actually be the case? Or should the second call to simulate not do anything as step 3 has already been executed?

There is also the interaction with explicit calls to step(). I.e. how many steps should be executed if the config is for 4 steps, but calls are step(); step(); simulate();. Should this execute 6 steps, or just 4?.

Changing this might break tests (or atleast change behaviour from intended.).

@Robadob
Copy link
Member

Robadob commented Oct 22, 2020

There's already an issue for this (or atleast they're two halves of the same problem and should be merged).

#265

@ptheywood
Copy link
Member Author

My bad for not looking. Will close this (and duplicate the body as a comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants