Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD - Typos in the table for conduits #1536

Closed
rpachaly opened this issue Sep 4, 2024 · 2 comments
Closed

SD - Typos in the table for conduits #1536

rpachaly opened this issue Sep 4, 2024 · 2 comments
Assignees
Labels
bug ready for testing Issue fixed and waiting to be tested

Comments

@rpachaly
Copy link
Collaborator

rpachaly commented Sep 4, 2024

I have the following comments for the conduits in the SD table:

  • Entry losses need to be changed to Entry Loss Coeff. This should be the coefficient, not the losses, the SD calculates the energy losses using this coefficient. The entry losses coeff depends on the type of entry to the conduit, this is used to calculate the minor loss.
  • Exit losses need to be changed to Exit Loss Coeff. This should be the coefficient, and it depends on the type of exit, this is used to calculate minor losses.
  • Average Losses need to be changed to Avg. Loss Coeff.
  • Flap gate losses should be change to Flap Gate (no losses) and should not be located in the Losses table, I think it needs to be moved to the Conduit properties

image

@rpachaly rpachaly added the bug label Sep 4, 2024
@rpachaly rpachaly self-assigned this Sep 4, 2024
@rpachaly rpachaly added the ready for testing Issue fixed and waiting to be tested label Sep 4, 2024
@rpachaly
Copy link
Collaborator Author

rpachaly commented Sep 4, 2024

@FLO-2DNoemi Done and merged on #1537

image

@FLO-2DKaren
Copy link
Collaborator

No issues on my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready for testing Issue fixed and waiting to be tested
Projects
None yet
Development

No branches or pull requests

2 participants