Outfall inside the channel

[rpachaly]

We should make sure that if the user places an outfall at any cell inside the channel (RB or internal CH element) the plugin always connects it to the left bank. In other words, the element in the outfall table is the LB element. Do we do this correction now in the plugin?

[rpachaly]

@FLO-2DNoemi @FLO-2DKaren

We need to have a more in-depth discussion on this. We also cannot have a hydraulic structure in the middle of the channel. So, a function that checks for the channel grid elements should be applied in many portions of the code. For some layers, it is possible to have a feature on the left bank and for others they cannot be placed on channel grid elements.

We need to have a variable containing all channel grid elements stored somewhere because it will take forever to do this check on the fly when adding a feature. It should be a dictionary leftbank: grid_elements, rightbank:grid_elements, and channel_interior:grid_elements.

The best place to create this variable is when schematizing the channel because we can have all grids intersected with the cross sections.

I'm thinking about the best way of storing it. One way is to add a new table to the geopackage. However, by doing this we'll need to port the geopackage and I was not planning to do such modification now, only when we upgrade to version 2.x. So, we need to figure out a different way of doing this.