Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSURGO and OSM Default #1580

Open
FLO-2DKaren opened this issue Oct 17, 2024 · 20 comments
Open

SSURGO and OSM Default #1580

FLO-2DKaren opened this issue Oct 17, 2024 · 20 comments
Assignees
Labels
bug enhancement ready for testing Issue fixed and waiting to be tested

Comments

@FLO-2DKaren
Copy link
Collaborator

Let's make the Default NO in these. I keep accidentally clicking yes.

infil.defaults.to.no.mp4
@rpachaly
Copy link
Collaborator

I solved this problem by changing the message to

image

However, I found a bug on the OSM. Working on it. When I finish this issue, remember to also test the OSM

@rpachaly
Copy link
Collaborator

What a weird error... The Land Use OSM data does not work if I have the OpenCL accelerator activated.

So, this is not on us. I'll merge this branch.

@rpachaly
Copy link
Collaborator

Done and merged on #1581

@rpachaly rpachaly added the ready for testing Issue fixed and waiting to be tested label Oct 29, 2024
@rpachaly rpachaly self-assigned this Oct 29, 2024
@FLO-2DKaren
Copy link
Collaborator Author

Failed Tests on QGIS 3.40.1 when data is added to Groups. See first and last part of video.
I think we should Save the Land Use and Soil to the project path because they are still good layers but you lose the data if you crash.
Here's the video and a test project.
https://flo-2d.sharefile.com/d-sb96c8df487da45a5b6234ebfa0720cbc

@rpachaly
Copy link
Collaborator

I'm seeing a lot of differences in this new QGIS version.

@rpachaly rpachaly removed the ready for testing Issue fixed and waiting to be tested label Dec 18, 2024
@FLO-2DKaren
Copy link
Collaborator Author

Yep. That's why I'm using 3.40 to test everything. We know the tests pass in 3.34 because you already did those.

@rpachaly
Copy link
Collaborator

What do you think about saving the soil layer and the land use and ALWAYS delete the intermediate calculation layers? We can get rid of that message then.

@FLO-2DKaren
Copy link
Collaborator Author

I don't have an issue with that so long as we can trace the files to the temp folder. Sometimes when we get an error, I trace the temp files and load them to see if they are complete or not.

@FLO-2DKaren
Copy link
Collaborator Author

I just added the bug label so we don't forget this one is important.

@rpachaly
Copy link
Collaborator

Karen, I was running a lot of tests here and I don't think this is related to groups or any flo-2d plugin code. This seems to be related to QGIS.

Do the following: run the OSM and SSURGO with the intermediate layers being saved. Then, just close the Compute Green-Ampt dialog and re-open it. Make sure that all fields are set correctly and click OK. It will run without any problems.

If you look into the QGIS Crash log, it is related to a combobox. It does not make sense. I was looking on the QGIS repo and a lot of people are complaining about QGIS crashes.

My opinion: let's keep on eye on this and double check when the next LTR is released.

@FLO-2DKaren
Copy link
Collaborator Author

OK I agree. That's a valid approach.

Did you add the Save Layer Code? I think its best to save them directly the gpkg. If so I'll run the tests again. I wanted to run them on several different projects before we close this issue.

  • Self Help
  • Euro project
  • Nevada project
  • Random state project

Things to check

  • Spread of all infil variables
  • Large Project
  • Processing time on fast computer vs work computer

@FLO-2DKaren
Copy link
Collaborator Author

Ooops closed it too soon.

Robson, That list is for me to test not you. Just some things I wanted to try out.

@rpachaly
Copy link
Collaborator

No, I haven't done that yet. I'm studying for the Limiting Froude number webinar and probably with touch on this again on Friday, if that's ok.

@rpachaly
Copy link
Collaborator

I did some changes on the layout (we'll need to change the documentation, sorry). But it looks simpler now.

image

Now it always save the soil layer and the land user layer to the geopackage. The other layers can be saved based on that checkbox.

I did a few tests here and all looked good.

It is on branch https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/compare/ssurgo-osm-default?expand=1

@FLO-2DNoemi
Copy link

FLO-2DNoemi commented Dec 26, 2024 via email

@rpachaly rpachaly added the ready for testing Issue fixed and waiting to be tested label Jan 7, 2025
@FLO-2DKaren
Copy link
Collaborator Author

K Test thoroughly.

@FLO-2DKaren FLO-2DKaren removed the ready for testing Issue fixed and waiting to be tested label Jan 11, 2025
@FLO-2DKaren
Copy link
Collaborator Author

Final calculation is crashing QGIS. Tested on Self Help Kit

osm.ssurgo.crash.message.mp4

@FLO-2DKaren
Copy link
Collaborator Author

3.40.1 error message.
The calculator isn't crashing QGIS but it's throwing this error.

ERROR 140119.1715: Green-Ampt infiltration failed!.
Error while calculating xksat.


Error:
TypeError: '>' not supported between instances of 'str' and 'int'

In file:
C:\Users/Karen/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\flo2d\flo2d_tools\infiltration_tools.py

In function:
calculate_xksat_weighted

On line 566:
^^^^^^^^^

@FLO-2DKaren
Copy link
Collaborator Author

Fix osm soil surrgo polygon overlap.

@rpachaly
Copy link
Collaborator

It it done on the branch https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/tree/ssurgo-osm-default

I did not merge it.

@rpachaly rpachaly added the ready for testing Issue fixed and waiting to be tested label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement ready for testing Issue fixed and waiting to be tested
Projects
None yet
Development

No branches or pull requests

3 participants