Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore 2009 models #1599

Open
FLO-2DKaren opened this issue Dec 13, 2024 · 14 comments
Open

Explore 2009 models #1599

FLO-2DKaren opened this issue Dec 13, 2024 · 14 comments
Assignees
Labels
enhancement ready for testing Issue fixed and waiting to be tested

Comments

@FLO-2DKaren
Copy link
Collaborator

No description provided.

@rpachaly rpachaly self-assigned this Dec 17, 2024
@rpachaly
Copy link
Collaborator

Karen, can you post some of the 2009 models and the main differences between the current models?

@FLO-2DKaren
Copy link
Collaborator Author

K

I have videos of this process in my Taney Short Course Folder.
The Taney project is a great place to start.
Share via Sharefile link not direct link.

@FLO-2DKaren
Copy link
Collaborator Author

Files to import.

TOLER.DAT
This file only has Line 1, and Line 2. The T line is not used.

Cont.dat
The super switch is a 0 or 1 in 2009 and it's a decimal in PRO.
Storm drain switch is not in 2009.

cadpts.dat and fplain.dat are required for 2009. it won't use topo.dat or mannings_n.dat

@FLO-2DKaren
Copy link
Collaborator Author

Export Ideas
Switch for 2009 to the cont table.
Export 2009 or PRO?

@rpachaly
Copy link
Collaborator

rpachaly commented Jan 8, 2025

Added the switch between 2009 and PRO on the Components Dialog. What do you think?

Image

The info is added to the cont table.

Image

I coded this in a way that has backwards compatibility.

@FLO-2DNoemi
Copy link

FLO-2DNoemi commented Jan 8, 2025 via email

@rpachaly
Copy link
Collaborator

rpachaly commented Jan 9, 2025

Hi @FLO-2DKaren and @FLO-2DNoemi

Here is the video for how I'm building the process to export to FLO-2D 2009 and FLO-2D Pro. Check this out and let me know what are your thoughts. https://flo-2d.sharefile.com/d-s8ac16e68eada4d79ab51ad98819c9463

I'll be working on the import.

@FLO-2DKaren
Copy link
Collaborator Author

@rpachaly

Hi Robson, This looks good. It is very clear and easy to follow for anyone who knows why they are using 2009 instead of pro.

The Super switch is here:
image

2009 wants that to be an integer with values of 0 and 1. It will result in writing the super.out file.
PRO always writes the super.out file and that variable was repurposed as the depressed depth variable. If it is set to 3ft, any cell that has all neighbors elevated more than 3ft will be printed to a file called depressed depth.out or something like that.

@FLO-2DKaren
Copy link
Collaborator Author

Some other notes.

In 2009 we used the DEPTOL value which is variable 2 on line 1 of toler.dat more common. We did not use wavemax which is variable 3 line 1 in toler.dat. We don't need that variable anymore but it was required as a zero in 2009.

@rpachaly rpachaly reopened this Jan 10, 2025
@rpachaly
Copy link
Collaborator

Nice! Thanks Karen. I already implemented these changes. Once the import process is done I'll push the branch.

@rpachaly
Copy link
Collaborator

I'll not do anything related to HDF5 yet.

@FLO-2DKaren
Copy link
Collaborator Author

2009 cannot use hdf5 so you won't be able to do anything about that.

@rpachaly
Copy link
Collaborator

That makes sense.

@rpachaly
Copy link
Collaborator

Karen, I think it is ready for testing. I did not merge the branch. It is on https://github.com/FLO-2DSoftware/qgis-flo-2d-plugin/tree/2009-models

What I did:

*Import data (.DAT) files: It is possible to import from FLO-2D 2009 and FLO-2D Pro models. All the variables are adjusted correctly and default values are set for missing values, such as TIME_ACCEL and WAVEMAX when importing from a 2009 project. First it tries to load the TOPO.DAT and MANNINGS_N.DAT to create the grid and, if these files are not available, it reads the CADPTS.DAT and FPLAIN.DAT. If these files are also not available, it will throw an error.

Import selected components files:* I adjusted the code for both several and single components.

Export data (*.DAT) files: I already showed this on the previous video.

Quick Run: The Quick Run button exports FLO-2D Pro or FLO-2D 2009 but it runs only FLOPRO.exe. Should we consider adding a Quick Run 2009 and Run FLO-2D 2009 buttons or should we only allow for exporting FLO-2D Pro when clicking on the Quick Run? @FLO-2DKaren @FLO-2DNoemi

I did a lot of testing importing and exporting. All seems to be fine. What I did not do was running FLO-2D 2009 and FLOPRO.

@rpachaly rpachaly added the ready for testing Issue fixed and waiting to be tested label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready for testing Issue fixed and waiting to be tested
Projects
None yet
Development

No branches or pull requests

3 participants