Skip to content

Commit 739af19

Browse files
committed
Remove setting of PORT on pfdcm with kservice
Fixes error validation failed: "PORT" is a reserved environment variable See https://github.com/knative/serving/blob/3e6d275e2bc402e7f6bea0a2d0744bb4c9679c75/pkg/apis/serving/k8s_validation_test.go#L1869-L1883
1 parent 6160212 commit 739af19

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

charts/chris/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ keywords:
1717
icon: ./logo_chris.png
1818

1919
type: application
20-
version: "1.0.0-alpha.3"
20+
version: "1.0.0-alpha.4"
2121
appVersion: "6.3.0-beta.7"
2222

2323
maintainers:

charts/chris/templates/pfdcm/pfdcm.yml

-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
{{- if (not (hasKey $values "containerPort")) -}}
99
{{- $_ := set $values "containerPort" .Values.pfdcm.service.port -}}
1010
{{- end -}}
11-
{{- $extraEnv := get $values "extraEnv" -}}
12-
{{- if (not (hasKey $extraEnv "PORT" )) -}}
13-
{{- $_ := set $extraEnv "PORT" (get $values "containerPort") -}}
14-
{{- end -}}
1511

1612
{{- $labels := get $values "labels" -}}
1713
{{- if (empty (get $labels "app.kubernetes.io/component")) -}}

0 commit comments

Comments
 (0)