Skip to content

Duplication of Ruined Book not working in the Echanting Apparatus #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Longva81 opened this issue Jan 18, 2025 · 2 comments
Closed

Duplication of Ruined Book not working in the Echanting Apparatus #6628

Longva81 opened this issue Jan 18, 2025 · 2 comments
Assignees
Labels
Bug FTB Evolution state: Fixed in Dev An issue is fixed in-dev and pending for release.

Comments

@Longva81
Copy link

Modpack

FTB Evolution

Modpack version

1.7.0

Launcher

CurseForge

Has the pack been modified

No

Log Files

No response

Describe the bug

When trying to duplicate the Ruined Book from Iron's Spells 'n Spellbooks in the Enchanting Apparatus from Ars Nouveau, it consuming 5000 source, but also the original book to make a new Ruined Book,

Steps to reproduce

  1. Use a Ruined Book as an ingredient on the Arcane Pedestal on the Ars Nouveau Encahnting Apparatus setup with a full Source Jar nearby.
  2. Use a Book and Quill in the apparatus.
  3. It consume 5000 source from the Source Jar and the animation starts.
  4. When the animation finishes, it consume the Ruined Book on the pedestal to make a new Ruined Book in the apparatus.

Expected behaviour

Expected to get an additional Ruined Book.

Screenshots

No response

Additional information

Suspect this should have been a recipe in the Imbuement Chamber and not the Enchantment Apparatus, since the Enchantment Apparatus consumes the ingredients.

@no-name-provided
Copy link

This is still a thing in 1.8.0, where I fell into the same trap.

@no-name-provided
Copy link

no-name-provided commented Jan 19, 2025

Changing the first "custom" function in 15_ars_nouveau.js (on line 8) to


event.custom({
"type": "ars_nouveau:enchanting_apparatus",
"keepNbtOfReagent": false,
"pedestalItems": [
{
"item": "irons_spellbooks:ruined_book"
}
],
"reagent": {
"item": "minecraft:writable_book"
},
"result": {
"count": 2,
"id": "irons_spellbooks:ruined_book"
},
"sourceCost": 5000
}).id("ftbevolution:ruined_book");


will make the enchanting apparatus produce two ruined books, which is probably the intention. (There was indentation when I wrote this, but I doubt it matters. JavaScript isn't Python. You just need to bump the count up to "2", anyway.)

Alternatively, inserting


event.custom({
"type": "ars_nouveau:imbuement",
"input": {
"item": "minecraft:writable_book"
},
"output": {
"count": 1,
"id": "irons_spellbooks:ruined_book"
},
"pedestalItems": [
{
"item": "irons_spellbooks:ruined_book"
}
],
"source": 5000
}).id("ftbevolution:ruined_book_alt");


immediately before the last line of the same file will give you your imbuement recipe. For the convenience of anyone else running into this, an edited file with both solutions is attached (just change the extension to ".js" and overwrite the original. You'll need to run /reload and wait a minute).

15_ars_nouveau.txt

Can we get clarification on which (if either) is intended?

@ArtpokeBr ArtpokeBr self-assigned this Jan 22, 2025
@ArtpokeBr ArtpokeBr added the state: Fixed in Dev An issue is fixed in-dev and pending for release. label Jan 22, 2025
@Gaz492 Gaz492 closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug FTB Evolution state: Fixed in Dev An issue is fixed in-dev and pending for release.
Projects
None yet
Development

No branches or pull requests

4 participants