Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count is saved even when params are missing #5

Open
manuelmeurer opened this issue Aug 23, 2014 · 3 comments
Open

Count is saved even when params are missing #5

manuelmeurer opened this issue Aug 23, 2014 · 3 comments

Comments

@manuelmeurer
Copy link
Contributor

I noticed that a count is saved in Redis even if one or more of the required parameters are missing.
For example:

voncount.config:

{
  "foo": {
    "bar": [
      {
        "id": [
          "my_param",
          "year",
          "month",
          "day"
        ],
        "count": "baz"
      }
    ]
  }
}

Even if I leave out my_param from my request (/foo), a count is saved (bar_2014_08_23).
Wouldn't it make sense to not count anything unless all params are present?

@manuelmeurer
Copy link
Contributor Author

Ping! 😸

@Ronsho
Copy link

Ronsho commented Sep 8, 2014

Hey Manuel,
It does make sense not to count when a param is missing. We are aware of this issue but we didn't have the time to handle it.

@manuelmeurer
Copy link
Contributor Author

Ok, cool, just wanted to hear your opinion about it. I will put it on the list of stuff I plan to implement in my fork. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants