Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out Realms authentication error in development environment #990

Closed
dicedpixels opened this issue Nov 22, 2023 · 3 comments
Closed
Milestone

Comments

@dicedpixels
Copy link
Contributor

Follow up to #948, the debug log contains a Realms authentication which can be removed in development environments.

[21:49:28] [IO-Worker-1/INFO] (Minecraft) Could not authorize you against Realms server: Invalid session id
[21:49:28] [IO-Worker-1/ERROR] (Minecraft) Couldn't connect to realms
 net.minecraft.client.realms.exception.RealmsServiceException: Realms authentication error with message 'Invalid session id'
	at net.minecraft.client.realms.RealmsClient.execute(RealmsClient.java:432) ~[minecraft-clientOnly-1f338b2c9f-1.20.2-net.fabricmc.yarn.1_20_2.1.20.2+build.4-v2.jar:?]
	at net.minecraft.client.realms.RealmsClient.clientCompatible(RealmsClient.java:218) ~[minecraft-clientOnly-1f338b2c9f-1.20.2-net.fabricmc.yarn.1_20_2.1.20.2+build.4-v2.jar:?]
	at net.minecraft.client.realms.RealmsAvailability.method_52627(RealmsAvailability.java:45) ~[minecraft-clientOnly-1f338b2c9f-1.20.2-net.fabricmc.yarn.1_20_2.1.20.2+build.4-v2.jar:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run$$$capture(CompletableFuture.java:1768) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
	at java.lang.Thread.run(Thread.java:840) ~[?:?]
@modmuss50 modmuss50 added this to the 1.5 milestone Nov 22, 2023
@modmuss50
Copy link
Member

The stacktrace has been removed by your PR, all thats left is the following log line:
[21:49:28] [IO-Worker-1/INFO] (Minecraft) Could not authorize you against Realms server: Invalid session id

I think this is fine to leave, as its not that scary/doesnt cause idea to switch away from the log out.

@dicedpixels
Copy link
Contributor Author

Yep, I mentioned it here: #991 (comment). The remaining line is a info line. I doubt it would cause any concern.

@modmuss50
Copy link
Member

Ah, sorry I missed that. Ill close this issue, as I dont think its needed.

Thanks :)

@modmuss50 modmuss50 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants