Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The AbstractFurnaceBlock.checkType method was not renamed to match BlockEntity.validateTicker #3677

Closed
haykam821 opened this issue Sep 27, 2023 · 0 comments · Fixed by #3678
Closed

The AbstractFurnaceBlock.checkType method was not renamed to match BlockEntity.validateTicker #3677

haykam821 opened this issue Sep 27, 2023 · 0 comments · Fixed by #3678
Assignees
@haykam821
Labels
bug Fixes or discusses a bug within the mappings

Comments

@haykam821
Copy link
Contributor

haykam821 commented Sep 27, 2023 •
edited
Loading

In #3643, the BlockEntity.checkType method was renamed to validateTicker to better suit the actual function of the method. However, a method serving a similar purpose in the AbstractFurnaceBlock class was not renamed correspondingly:

yarn/mappings/net/minecraft/block/AbstractFurnaceBlock.mapping

Lines 8 to 11 in c06d7ae

METHOD method_31617 checkType (Lnet/minecraft/class_1937;Lnet/minecraft/class_2591;Lnet/minecraft/class_2591;)Lnet/minecraft/class_5558;
ARG 0 world
ARG 1 givenType
ARG 2 expectedType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haykam821 haykam821

Labels
bug Fixes or discusses a bug within the mappings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename the AbstractFurnaceBlock.checkType method to validateTicker haykam821/yarn
1 participant
@haykam821