Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add frontend for merging textures #124

Open
3vorp opened this issue Feb 15, 2024 · 3 comments
Open

[Feature] Add frontend for merging textures #124

3vorp opened this issue Feb 15, 2024 · 3 comments

Comments

@3vorp
Copy link
Contributor

3vorp commented Feb 15, 2024

Is your feature request related to a problem?

There's no good way to merge two textures currently without manually copying over everything.

Describe the feature you'd like

The API backend for merging two textures has been done for some time (PUT /textures/merge/{add_id}/{remove_id}), but there's no frontend for actually doing it with a GUI. I'm not sure what the best way to do this would be — I'm thinking either a button on the texture modal next to the save button or a button in the texture search next to the edit/delete buttons could bring up a modal that lets you enter a texture ID to be merged in and deleted.

Screenshot(s)

image
image

Notes

No response

@3vorp 3vorp added the enhancement New feature or request label Feb 15, 2024
@TheRolfFR
Copy link
Member

Don't merge this one without I give a personal touch to the code.
Please make a PR for it.

An icon button on the texture item is a better solution, because we wouldn't have to update the edit modal after the merge.

The texture to remove could be something more visual with a searchbox and an item preview.

The "texture to add" is terrible description, I would call it "Destination texture", and I would like the input to be disabled.

I would also add a confirmation sentence to avoid misclicks.

More generally, a little more visuals would help preview the changes.

@TheRolfFR
Copy link
Member

TheRolfFR commented Jun 27, 2024

Did you do something on this yet @3vorp?

@3vorp
Copy link
Contributor Author

3vorp commented Jun 27, 2024

No, but I've also built the backend for the same feature for user merging and ID changing so whatever UI we come with here should probably be used for the user page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants