Prefer Null-conditional operators over ternaries

[amanda-mitchell]

The patterns

foo != null ? foo.Bar.OtherStuff : null

and

foo.HasValue ? foo.Value.Bar.OtherStuff : null // foo is of type Nullable<T>

Should be simplified to

foo?.Bar.OtherStuff

[EthanRutherford]

VS is constantly listing this as an "info" level message for me. I'm unclear on the details, but perhaps this could be done by simply upping the log level on the built in analyzer?

[bgrainger]

As @EthanRutherford has commented, this is already available as IDE0031: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0031. No need to build our own version.

[bgrainger]

I don't think IDE0031 catches Nullable<T>, so this analyser could handle that case:

foo.HasValue ? foo.Value.Bar.OtherStuff : null // foo is of type Nullable<T>