Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks in DataStore #49

Open
pilwon opened this issue Jul 6, 2015 · 1 comment
Open

Memory leaks in DataStore #49

pilwon opened this issue Jul 6, 2015 · 1 comment

Comments

@pilwon
Copy link
Contributor

pilwon commented Jul 6, 2015

There is DataStore.saveFamousFrameworkComponent to register key to COMPONENTS object but no function exists to unregister key from it. This causes a memory leak problem over time in any component that uses $ifs and $repeats where children nodes are dynamically added/removed. We need a destructor function that knows how to reach in to these places and clean things up.

@arkadyp
Copy link

arkadyp commented Jul 6, 2015

Thanks for bringing this up @pilwon. I will work on putting in a deregister method and calling it in the appropriate place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants