fancynpcs: remove the Player UUID from the Npc maps instead setting it to default value

also don't set the default value on Join
remove code comments in favor of JDoc for method

Author: TheosRee

plugins/fancynpcs/src/main/java/de/oliver/fancynpcs/listeners/PlayerJoinListener.java

@@ -2,7 +2,6 @@
 
 import com.destroystokyo.paper.profile.ProfileProperty;
 import de.oliver.fancynpcs.FancyNpcs;
-import de.oliver.fancynpcs.api.Npc;
 import de.oliver.fancynpcs.api.skins.SkinData;
 import de.oliver.fancynpcs.v1_20.PacketReader_1_20;
 import org.bukkit.Bukkit;
@@ -19,13 +18,6 @@ public void onPlayerJoin(PlayerJoinEvent event) {
             PacketReader_1_20.inject(event.getPlayer());
         }
 
-        for (Npc npc : FancyNpcs.getInstance().getNpcManagerImpl().getAllNpcs()) {
-            npc.getIsVisibleForPlayer().put(event.getPlayer().getUniqueId(), false);
-            npc.getIsForcedHidden().put(event.getPlayer().getUniqueId(), false);
-            npc.getIsLookingAtPlayer().put(event.getPlayer().getUniqueId(), false);
-            npc.getIsTeamCreated().put(event.getPlayer().getUniqueId(), false);
-        }
-
         // don't spawn the npc for player if he just joined
         FancyNpcs.getInstance().getVisibilityTracker().addJoinDelayPlayer(event.getPlayer().getUniqueId());
         FancyNpcs.getInstance().getScheduler().runTaskLater(null, 20L * 2, () -> FancyNpcs.getInstance().getVisibilityTracker().removeJoinDelayPlayer(event.getPlayer().getUniqueId()));

plugins/fancynpcs/src/main/java/de/oliver/fancynpcs/listeners/PlayerQuitListener.java

@@ -3,24 +3,26 @@
 import de.oliver.fancynpcs.FancyNpcs;
 import de.oliver.fancynpcs.api.Npc;
 import de.oliver.fancynpcs.api.events.NpcStopLookingEvent;
-import org.bukkit.Bukkit;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.Listener;
 import org.bukkit.event.player.PlayerQuitEvent;
 
+import java.util.UUID;
+
 public class PlayerQuitListener implements Listener {
 
+    /**
+     * Removes the player UUID from the Npcs states, except last interaction.
+     */
     @EventHandler
     public void onPlayerQuit(PlayerQuitEvent event) {
+        UUID uuid = event.getPlayer().getUniqueId();
         for (Npc npc : FancyNpcs.getInstance().getNpcManagerImpl().getAllNpcs()) {
-            // Changing isLookingAtPlayer state (of event player) to false.
-            // This allows the NpcStartLookingEvent to be called when player joins back. (Because otherwise, state would remain true and no change would be detected)
-            npc.getIsVisibleForPlayer().put(event.getPlayer().getUniqueId(), false);
-            npc.getIsForcedHidden().put(event.getPlayer().getUniqueId(), false);
-            npc.getIsLookingAtPlayer().put(event.getPlayer().getUniqueId(), false);
-            npc.getIsTeamCreated().put(event.getPlayer().getUniqueId(), false);
-            // Calling NpcStopLookingEvent.
-            Bukkit.getPluginManager().callEvent(new NpcStopLookingEvent(npc, event.getPlayer()));
+            npc.getIsVisibleForPlayer().remove(uuid);
+            npc.getIsForcedHidden().remove(uuid);
+            npc.getIsLookingAtPlayer().remove(uuid);
+            npc.getIsTeamCreated().remove(uuid);
+            new NpcStopLookingEvent(npc, event.getPlayer()).callEvent();
         }
     }
 }