Skip to content

Conversation

@bennycallanan
Copy link

THIS IS MAINLY FOR DISCUSSION TO FIND BEST SOLUTION

📋 Description

Please include a summary of the changes and the related issue(s).
What is this PR solving? Why is it needed?

This isn't so much a need but could be considered a big QOL update. The drafted code is far from the final code I'd think would be viable but this build opens up conversation to be had.

✅ Checklist

  • My code follows the project's coding style and guidelines
  • I have tested my changes locally and they work as expected
  • I have added necessary documentation (if applicable)
  • I have linked related issues using Fixes #issue_number or Closes #issue_number
  • I have rebased/merged with the latest main branch

🔍 Changes

Please provide a brief summary of the changes made in this PR.

The end goal of this PR is to find a good and viable solution for static skins to be applied to NPC's without the need to have to manually download skins from websites such as namemc. Using the native Mojang and MineSkin handlers found in FancyNPCs, I am downloading the skin of the user and applying there skin from the local file to provide a static enviroment.


🧪 How to Test

Please describe how to manually test the changes made in this PR.

  1. Type /npc skin <npc> <name> --static

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant