Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: hysteresis #24

Open
ejfdickinson opened this issue Feb 8, 2023 · 4 comments
Open

Feature request: hysteresis #24

ejfdickinson opened this issue Feb 8, 2023 · 4 comments

Comments

@ejfdickinson
Copy link
Collaborator

Provide support in the BPX standard for electrode OCPs to be defined as general functions of more parameters, in order to define a hysteresis model. The simplest such example could be the sigmoid hysteresis model (distinct charge/discharge OCP profiles) in PyBaMM.

[request from industrial contributor]

@ejfdickinson
Copy link
Collaborator Author

For the next version release, this can be satisfied through #26

@tommaull
Copy link

@ejfdickinson - I know I said I'd stop disagreeing with you, but I think based on recent experience we need to include decay. Also, I think it's a bit cleaner/clearer to include a single OCP with a hysteresis term. This amounts to the same thing, but is easier to convey.

@ejfdickinson
Copy link
Collaborator Author

ejfdickinson commented Sep 28, 2023

@tommaull Noted and agreed (with the benefit of 6 months' thinking time!) for any possible standard extension. A decay rate can always be short-circuited to be instantaneous if desired.

We recognised this uncertainty / absence of consensus, so we have not yet committed (BPX v0.4) to any explicit standardisation of hysteresis parameters.

In the immediate term, the open-ended user-defined parameter section (#26, PR #44), scheduled for BPX v0.4, satisfies sharing of parameters using either OCP approach (two OCPs / one OCP + hysteresis term). Also this would support the inclusion of a decay rate if desired. As this would fall outside the BPX equation standard, compatibility with BPX readers to convert to e.g. a compatible pybamm.ParameterValues object would need to be extended manually to satisfy any chosen user-defined format. I'd see this as very little work, however.

@ejfdickinson
Copy link
Collaborator Author

I suggest to revisit this now that there is a standard implementation of the Wycisk/Plett model] in PyBaMM (scheduled for 24.5 release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants