Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial SOC #8

Closed
4 tasks done
rtimms opened this issue Nov 22, 2022 · 1 comment
Closed
4 tasks done

Initial SOC #8

rtimms opened this issue Nov 22, 2022 · 1 comment

Comments

@rtimms
Copy link
Collaborator

rtimms commented Nov 22, 2022 •
edited
Loading

  • Add min/max stoichiometries for electrodes
  • Remove initial concentrations
  • Validate the sto limits subbed into the OCPs give the correct voltage limits
  • Add helper function to return initial concentrations given a target SOC

Relates to #4
@rtimms rtimms mentioned this issue Nov 24, 2022
Merged
ikorotkin added a commit to ikorotkin/BPX that referenced this issue Jun 19, 2023
@ikorotkin
Validate the sto limits according to issue FaradayInstitution#8
7411768
@ikorotkin ikorotkin mentioned this issue Jun 19, 2023
Merged
@rtimms
Copy link
Collaborator Author

rtimms commented Oct 19, 2023

fixed by #32

@rtimms rtimms closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rtimms