-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to follow gymnasium's implementation #418
Update CI to follow gymnasium's implementation #418
Conversation
hooks: | ||
- id: mixed-line-ending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not used in gymnasium? Seems useful, have had issues with line endings before. Also I feel like we should use the same pre commit config across farama projects similar to farama notifications and the furo documentation stuff. Might go and add these things to pettingzoo. For consistency’s sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this is done in the end-of-file-fixer
within pre-commit-hooks
--tag metaworld-docker . | ||
- name: Run tests | ||
run: docker run metaworld-docker pytest tests/* | ||
# - name: Run doctests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do exactly? Should we have doc tests for other projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some googling looks useful, though i don’t think many other farama projects do that style of docs with code examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a copy from Gymnasium where we run this.
I recommend it for having docstrings that are correct and will raise an error if the code changes etc
@reginald-mclean Are you happy for me to merge this? |
As part of the process of updating metaworld, this PR updates the CI (testing and pre-commit) to follow gymnasium's implementation.
In particular, the dockerfile, testing implementation and pre-commit config were updated
@reginald-mclean I'm a bit surprised that the testing takes 40+ minutes to run.
We should do an investigation to understand why it takes so long, I would expect 5 - 10 minutes max.