Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Commit f5cd97c

Browse files
Merge pull request #49 from FastReports/AddedWindowsFormsSDKforNet5windows
Added WindowsForms SDK and removed System.Drawing.Common dependency
2 parents 6c96aa3 + 7d72ff7 commit f5cd97c

File tree

3 files changed

+21
-4
lines changed

3 files changed

+21
-4
lines changed

Nuget/FastReport.Compat.nuspec

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
3+
<metadata>
4+
<frameworkReferences>
5+
<group targetFramework="net5.0-windows7.0">
6+
<frameworkReference name="Microsoft.WindowsDesktop.App.WindowsForms" />
7+
</group>
8+
</frameworkReferences>
9+
</metadata>
10+
</package>

build/build.cake

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,10 @@ Task("Compat")
163163

164164
var dependencies = new List<NuSpecDependency>();
165165
AddNuSpecDep(null, null, ".NETFramework4.0");
166-
AddNuSpecDepCore("System.Drawing.Common", SystemDrawingCommonVersion);
166+
// System.Drawing.Common reference doesn't included in net5.0-windows target
167+
AddNuSpecDep("System.Drawing.Common", SystemDrawingCommonVersion, ".NETStandard2.0");
168+
AddNuSpecDep("System.Drawing.Common", SystemDrawingCommonVersion, ".NETStandard2.1");
169+
AddNuSpecDep("System.Drawing.Common", SystemDrawingCommonVersion, tfmCore30);
167170
AddNuSpecDepCore("Microsoft.CodeAnalysis.CSharp", CodeAnalysisCSharpVersion);
168171
AddNuSpecDepCore("Microsoft.CodeAnalysis.VisualBasic", CodeAnalysisVisualBasicVersion);
169172
AddNuSpecDep("System.Windows.Extensions", "4.6.0", tfmCore30);
@@ -196,7 +199,7 @@ Task("Compat")
196199
};
197200

198201
// Pack
199-
NuGetPack(nuGetPackSettings);
202+
NuGetPack(Path.Combine(solutionDirectory, "Nuget", nuGetPackSettings.Id + ".nuspec"), nuGetPackSettings);
200203

201204
// Local functions:
202205

src/FastReport.Compat-Windows/FastReport.Compat-Windows.csproj

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
22

33
<PropertyGroup>
44
<TargetFrameworks>net40;$(CustomTargetFrameworks)</TargetFrameworks>
55
<DefineConstants>$(DefineConstants);NETCOREWIN</DefineConstants>
6+
<UseWindowsForms>true</UseWindowsForms>
67
<AssemblyName>FastReport.Compat</AssemblyName>
78
<PackageId>$(AssemblyName)</PackageId>
89
<ProduceReferenceAssembly>false</ProduceReferenceAssembly>
@@ -25,9 +26,12 @@
2526

2627
<Import Project="$(SlnDir)UsedPackages.version"/>
2728
<ItemGroup Condition="'$(TargetFramework)'!='net40'">
28-
<PackageReference Include="System.Drawing.Common" Version="$(SystemDrawingCommonVersion)" />
2929
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="$(CodeAnalysisCSharpVersion)" />
3030
<PackageReference Include="Microsoft.CodeAnalysis.VisualBasic" Version="$(CodeAnalysisVisualBasicVersion)" />
31+
</ItemGroup>
32+
33+
<ItemGroup Condition="'$(TargetFramework)'=='netcoreapp3.0'">
34+
<PackageReference Include="System.Drawing.Common" Version="$(SystemDrawingCommonVersion)" />
3135
<PackageReference Include="System.Windows.Extensions" Version="4.6.0"/>
3236
</ItemGroup>
3337

0 commit comments

Comments
 (0)