Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LockFreePool implementation in 2.18 (remove from 3.0) #1271

Closed
cowtowncoder opened this issue Apr 20, 2024 · 3 comments
Closed

Deprecate LockFreePool implementation in 2.18 (remove from 3.0) #1271

cowtowncoder opened this issue Apr 20, 2024 · 3 comments
Labels
2.18 Issues planned at earliest for 2.18
Milestone
2.18.0

Comments

@cowtowncoder
Copy link
Member

Due to reported issues wrt Lock-Free pool implementation (temporarily used as the default RecyclerPool for 2.17.0), its use seems dangerous. If we cannot solve (or at least severely mitigate) the problems, it seems necessary to deprecate this implementation, and remove from 3.0.

No decision is yet made but I created this issue so we can consider it.
@cowtowncoder cowtowncoder added the 2.18 Issues planned at earliest for 2.18 label Apr 20, 2024
@cowtowncoder
Copy link
Member Author

/cc @mariofusco @pjfanning @JooHyukKim @franz1981

@JooHyukKim
Copy link
Member

JooHyukKim commented Apr 20, 2024 •
edited
Loading

(Just connecting things) Issue stemmed out from #1260 (comment).

The issue can also start with "Fix or deprecate" to align with the original comment.

@cowtowncoder cowtowncoder mentioned this issue May 5, 2024
Closed
@cowtowncoder cowtowncoder added this to the 2.18.0 milestone May 10, 2024
@cowtowncoder cowtowncoder changed the title Deprecate LockFreePool implementation from 2.18, remove from 3.0? Deprecate LockFreePool implementation in 2.18 (remove from 3.0) May 10, 2024
cowtowncoder added a commit that referenced this issue May 10, 2024
@cowtowncoder
Fix #1271: reprecate LockFreePool in 2.18 (to be removed from 3.0)
6dcc09a
@cowtowncoder
Copy link
Member Author

Deprecated in 2.18; removed from 3.0 (master).

@artemus717 artemus717 mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.18 Issues planned at earliest for 2.18
Projects
None yet
Milestone
2.18.0
Development

No branches or pull requests
2 participants
@cowtowncoder @JooHyukKim