-
Notifications
You must be signed in to change notification settings - Fork 6
JSTEP 3
(Back to JSTEP page)
Related change issues: [fill me in]
Tatu Saloranta (@cowtowncoder)
- 2019-01-26: first skeletal revision
- 2019-02-10: copy existing plan over from earlier wiki page, with minimal edits
- 2019-09-10: Update wrt work on databind#2237
- 2021-10-11: Update potential
JsonNodeFeature
s - 2022-01-04: Add
ALLOW_ARRAY_MERGE
,OBJECT_MERGE
JsonNodeFeature
s. - 2022-01-16: Add links to JSTEP-7 (new
JsonNodeFeature
as one ofDataTypeFeature
s) - 2024-06-02: Remove details of
JsonNodeFeature
Although "Tree Model" -- operating on json content via JsonNode
-based object model which represents content exactly as-is, without transformations -- has been around since Jackson 1.0, it has not been worked on as extensively as full databinding to/from POJOs. But it is extensively used and valued by users due to its flexibility. Over time some of original design choices have proven problematic (for example methods not being able to throw JsonProcessingException
for invalid coercions; or returning of JsonNode
for methods in contaner nodes, preventing chaining of many calls), and in a way that can not be changed without breaking backwards compatibility.
With 3.0 we have a perfect opportunity to further improve JsonNode
API, as well as fix problems in return type declarations. We can also benefit from other changes, in particular JSTEP-4 which will make it possible for all methods to throw properly typed exceptions.
As of Jackson 2.x, only some of DeserializationFeature
s (and few if any SerializationFeature
s) affect handling of JsonNode
. This is due to most of them being POJO-centric, as JsonNode
is meant to be faithful representation of JSON that was read, or is to be written out, with few changes.
But users do have legitimate need/desire to make some changes. It's just that these changes are not necessarily aligned with changes to POJO handling. For this reason, Jackson 2.14 added JsonNodeFeature
for configurability.
More detail found under JSTEP-7.
With 3.0, JsonProcessingException
becomes unchecked (see JSTEP-4)
This is relevant for JsonNode
, too, since we can start throwing formal Jackson exceptions, without having to declare them separately for all (or just some) accessors.
This is relevant for a few entries here:
-
JsonNode.toString()
can pass any exceptions for real serialization as-is, with no additional wrapping
However: I think it also makes sense to introduce at least one new Jackson exception type, like:
-
ValueCoercionException
(similar to new Streaming API exception,InputCoercionException
)
which can then be used by methods that attempt coercion (like JsonNode.asIntValue()
), but fail due to incompatible types (or perhaps parsing error, from String to number).
This exception type should retain and expose information like:
- Source token type (
JsonToken.VALUE_STRING
) - Target shape (as token, like
JsonToken.VALUE_NUMBER_INT
) - If available, target Java type (
java.lang.Integer#type
forint
, for example) - We do not necessarily have information on path, but possibly exception catch/rethrow could re-create this
- For
ContainerNode
(ObjectNode
,ArrayNode
):-
removeNullValues()
(or: separate for object ("removeNullProperties()") vs array ("removeNullElements")?) -
clear()
/removeAll()
(remove all entries)
-
It should be possible to stream through both values (array elements, values of properties), and in case of ObjectNode
, entries (name and value). Not sure what is the best Java 8 pattern to follow, perhaps take consumers?
Maybe allow a way to "map"? Might become problematic for ObjectNode
, if and when modifying while traversing: maybe should just create a new ObjectNode
/ ArrayNode
if and when making any change(s)?
Will definitely need help defining good Java 8 API additions here
As of 2.x, there are a few accessors for type like, say, int
:
-
intValue()
: returnint
if (and only if!) we got numeric integer node (JsonToken.VALUE_NUMBER_INT
) -- but won't throw exception, returns default value (0
) otherwise -
asInt()
: same asasInt(0)
-
asInt(int defaultValue
): returnint
value fromJsonToken.VALUE_NUMBER_INT
(if within value range) OR if coercible (fromdouble
orString
); otherwise returndefaultValue
But none actually throws exception: partly due to historical reasons (was not done initially), and also since methods do not expose JsonProcessingException
(or IOException
). So, due to backwards compatibility.
So there are couple of things to improve:
- Should allow throwing of exceptions, for case where no default is specified. We can now do this more easily as we throw unchecked exception -- meaning accessors are still safe with Java 8 streaming
- Should allow use of Java 8
Optional
, as that is useful forstream()
operations (and now we can use Java 8 features)
This would leave to bigger set of methods, once again for int
:
-
intValue()
as before, return value ifJsonToken.VALUE_NUMBER_INT
, within Javaint
range -- but if not, throw exception -
intValue(int defaultValue)
asintValue()
except returnsdefaultValue
instead of exception -
optIntValue()
similar tointValue()
but returnsOptionalInt
, either present (as perintValue()
) or absent (instead of exception) -
asInt()
(orasIntValue()
?) similar tointValue()
but allows coercion fromdouble
andString
(and possible with config, fromtrue
/false
). But if not, throw exception -
asInt(int defaultValue)
likeasInt()
but instead of exception, returndefaultValue()
for case of no valid value -
asOptInt()
(maybe?): similar toasInt()
but instead of exception, return "absent" value
Now: set of operations may be smaller for other more esoteric types. We should also have generic
opt(String / int)
as counterpart to get()
/ path()
, which would return Optional<JsonNode>
.
Is there need for casting with something like
-
asObject()
? (requires forward-ref to subtype, not really optimal -- although could maybe use local type bound of ` -- need to test) - similarly,
asArray()
?
- Rename methods with "text" to use "string", similarly types ("TextNode" -> "StringNode"): deprecate old methods in cases where significant usage exists (
textValue()
,asText()
) - "Bulk" add methods for scalars? ("addAll()", "putAll()") -- and maybe just for simple things like
String
,int
,long
values?- Maybe via
JsonNodeFactory
?
- Maybe via
-
JsonNode.toString()
will guarantee valid JSON output (assuming default vanillaObjectMapper
settings) *JsonNode.isEmpty()
works as alias for idiomsize() == 0
(note: these were added via databind#2237)
-
required(String / int)
for basically "get, throw exception if no node with name/index) -
requiredAt(JsonPointer)
: same as above, but withJsonPointer
-
require()
-- returnsJsonNode
(or subtype, co-variant) unlessMissingNode
; ifMissingNode
, throw exception (unchecked, Jackson-specific) -
requireNonNull()
-- same asrequire()
, but fail both forMissingNode
andNullNode