-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerate JAX-RS 2.2 in jackson-module-jaxb-annotations so that it can be deployed in Liberty alongside features which use 2.2 #233
Comments
Two sections you show seem to be identical? Also, not sure how JAX-RS is related here (Jackson does have JAX-RS/Jakarta-RS providers but those are separate from modules here). But one thing to note is that there are 2 modules: |
Hi @cowtowncoder there is a tiny difference in the code blocks. The [min,max) version toleration changes between the two. Today the jaxb modules tolerate |
Ah! Easy to miss. So, I'd be open for a PR although slightly worried whether it might cause issues for other users. But I guess as long as whatever is including module specifies 2.3 or later as dependency, it should not become problematic. So, PR against |
Hi @cowtowncoder I raised a PR at the 2.17 level, as we frequently update to latest version so would be looking to have this in future releases as well. I wasn't sure if having the PR at 2.16 meant it wouldn't go in subsequent releases. I can PR again at 2.16 if that is preferable. |
@JDUNNIN I always merge forward, so With the exception that if the change is to So 2.16 would be preferable. |
@cowtowncoder I've recreated the PR at 2.16 👍 Thanks |
When using a Liberty container image such as
icr.io/appcafe/websphere-liberty:23.0.0.9-full-java11-openj9-ubi
and trying to use the jackson-module-jaxb-annotations-2.16.0.jar we get a conflict due to two implementations ofjavax.xml.bind
being available.The features we need to use within Liberty only supply the 2.2 implementation.
Looking at jackson-module-jaxb-annotations-2.16.0.jar we can see it has compile dependencies on
jakarta.xml.bind-api
2.3.2 and so provides an implementation at 2.3. This then causes the conflict.This issue is to request that jaxb annotations be updated in some way to change the toleration that ends up in the /META-INF/MANIFEST.MF file in the Import-Package section to be:
Instead of what is currently has:
Thanks
The text was updated successfully, but these errors were encountered: