Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm@5 and package-lock.json #1561

Open
FelisCatus opened this issue Jul 20, 2018 · 0 comments · May be fixed by #1743
Open

Use npm@5 and package-lock.json #1561

FelisCatus opened this issue Jul 20, 2018 · 0 comments · May be fixed by #1743

Comments

@FelisCatus
Copy link
Owner

FelisCatus commented Jul 20, 2018

We've got some really inconsistent builds here (v.s. w/o cache).

I'd say we should lock our package versions and use the lock file as cache keys. This would ensure reproducible builds and make everyone's life easier.

(If possible, it is also time to move away from bower, which does not support lock files.)

@yfdyh000 yfdyh000 linked a pull request Jan 26, 2019 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant