From 8c6ce178b0640a52c39c20b60a05c1b23e92e9c8 Mon Sep 17 00:00:00 2001 From: Fadil Nohur Date: Sun, 27 Aug 2017 22:08:43 +0100 Subject: [PATCH] Enabling titlebar colour support on Win 10. --- README.md | 14 +++++--------- images/theme_tab_background.png | Bin 641 -> 641 bytes manifest.json | 10 +++++----- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/README.md b/README.md index f64f082..41a0ef6 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,8 @@ # Material Incognito Dark Theme A theme that adds the dark Incognito Mode colour scheme to the normal mode of Chrome. +**Windows 10 users - please go to chrome://flags, scroll down to Custom-drawn Windows 10 Titlebar and press Enable. This will enable titlebar colour.** + With the release of Material Design in Google Chrome, Incognito mode uses a dark colour scheme to distinguish it from normal mode. This theme imitates that colour scheme and applies it throughout the whole browser. Please leave comments about my theme if you wish; I enjoy seeing feedback. @@ -17,22 +19,16 @@ All elements of the official Incognito mode dark colour scheme have been ported I could rectify this for Windows users by using Stardock's WindowBlinds software, but this would cost me $10 to develop the solution and $10 for every person that wants to use it. If enough people ask for this in the comments, I will follow through and develop a solution, but otherwise it's a waste of money for all involved. -2. I cannot colour the titlebar a dark colour in Windows without also introducing Windows 7-style minimise, maximise and close buttons. - -This issue has been fixed in Chrome 58+, but the fix is a Chrome flag that has to be manually enabled. A future Chrome update will auto-enable this feature; when that update has been pushed to most people, I will update this theme accordingly to take advantage of this. - -For the time being, on Windows 10 (version 1607), you can go to the Settings app -> Personalisation -> Colours, choose the second shade of grey in the sixth row of colours, and then toggle on "Show colour on title bar". This colours the titlebar grey to match Material Incognito Dark Theme. For other OSs, please consult alternative documentation. - -3. The bookmark bar colour is a lighter grey when compared to the official Incognito mode dark colour scheme. +2. The bookmark bar colour is a lighter grey when compared to the official Incognito mode dark colour scheme. This is for a few reasons. Firstly, choosing a darker colour messes up the Incognito mode guy colour in the top left corner. Secondly, the colours of the bookmark bar, the download bar and the status bar that appears when hovering over a link are tied to each other. The status bar colour is currently accurate, but the bookmark bar colour cannot be made accurate without making the status bar colour inaccurate and vice versa. This catch-22 situation is why the bookmark bar colour is currently inaccurate. -4. There is a upper white line between the URL bar row and bookmark bar. +3. There is a upper white line between the URL bar row and bookmark bar. ~~I cannot do anything about this white line; to speed up its removal, please star this issue here: https://bugs.chromium.org/p/chromium/issues/detail?id=628312 .~~ This is no longer an issue in Chrome 61. Thank you Google and all the people who raised/starred this issue! -5. There is a lower white line underneath the bookmark bar. +4. There is a lower white line underneath the bookmark bar. ~~In theory, I can remove this line; in practice, I cannot. The colour of this line is tied to the bookmark bar text colour. If the bookmark bar text is white, then so too is that line. If the bookmark bar text is black, then that line will be black as well and will fade into the background, but the bookmark bar text itself will be unreadable. This catch-22 situation is why this line must stay white. If someone opens up a Chromium bug tracker entry to allow these two elements to be set independently, I will star the entry and link to it here.~~ This is no longer an issue in Chrome 61. Thank you Google and all the people who raised/starred this issue! diff --git a/images/theme_tab_background.png b/images/theme_tab_background.png index 0e3583329b5913e067c18f5e0d4351481486e3e3..e4551901f5a6849bb625df9e504df965de7ef083 100644 GIT binary patch delta 36 qcmZo=d#Wzp$P!W4hot8 delta 36 qcmZo9{mka|