Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add admin questions #185

Merged
merged 9 commits into from
Jan 29, 2024
Merged

add admin questions #185

merged 9 commits into from
Jan 29, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Jan 28, 2024 •
edited by FidelusAleksander
Loading

PR Type

  • Adding new question(s)

Warning: We do not support the inclusion of questions directly copied from official GitHub certification exams. Please only submit original questions and content that you have created.

  • Other content changes (updating questions, answers, explanations or study resources)
  • Code changes (non-content)
  • Documentation changes
  • Other

What's new?

Related issue(s)

#89

Screenshots

@github-actions github-actions bot added admin Related to GitHub Admin exam content Related to the content of the site labels Jan 28, 2024
FidelusAleksander
FidelusAleksander requested changes Jan 29, 2024
View reviewed changes
Copy link
Owner

@FidelusAleksander FidelusAleksander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things except for the question 13 which I am not a fan of. Please take a look at that one again

  • Make sure pre-commit checks pass

content/questions/admin/question-013.md Outdated Show resolved Hide resolved
content/questions/admin/question-013.md Show resolved Hide resolved
content/questions/admin/question-013.md Outdated Show resolved Hide resolved
content/questions/admin/question-021.md Outdated Show resolved Hide resolved
content/questions/admin/question-022.md Outdated Show resolved Hide resolved
content/questions/admin/question-019.md Outdated Show resolved Hide resolved
garysassano and others added 2 commits January 29, 2024 12:59
@garysassano @FidelusAleksander
Update content/questions/admin/question-019.md
19eabae 
Co-authored-by: Aleksander Fidelus <63016446+FidelusAleksander@users.noreply.github.com>
@garysassano @FidelusAleksander
Update content/questions/admin/question-022.md
1a8aa27 
Co-authored-by: Aleksander Fidelus <63016446+FidelusAleksander@users.noreply.github.com>
garysassano and others added 3 commits January 29, 2024 14:14
@garysassano
Update question-013.md
b01efdd
@garysassano @FidelusAleksander
Update content/questions/admin/question-021.md
f985646 
Co-authored-by: Aleksander Fidelus <63016446+FidelusAleksander@users.noreply.github.com>
@garysassano
remove extra comma
5a3f119
@FidelusAleksander
Copy link
Owner

FidelusAleksander commented Jan 29, 2024 •
edited
Loading

LMK once you fix pre-commit and I will merge this.

pre-commit run -a

Please also add the missing words that are raising warnings in https://github.com/FidelusAleksander/ghcertified/blob/master/cspell.json

"SCIM"
"Keycloak"
"Entra"

FidelusAleksander
FidelusAleksander approved these changes Jan 29, 2024
View reviewed changes
Copy link
Owner

@FidelusAleksander FidelusAleksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for adding this 🚀

@FidelusAleksander FidelusAleksander merged commit 96257a0 into FidelusAleksander:master Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FidelusAleksander FidelusAleksander FidelusAleksander approved these changes

Assignees
No one assigned
Labels
admin Related to GitHub Admin exam content Related to the content of the site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garysassano @FidelusAleksander