Skip to content

Weapon self-buffs don't apply when opponent is killed and can't counter #690

@masterofcontroversy

Description

@masterofcontroversy

Weapon self-buffs are not applied if the opponent is killed in a combat where they cannot counter.
The cause appears to be that, due to its hook address, SetDebuffs is only called if the battle target can counter, and SealSkills will not apply weapon debuffs if either unit died in combat.

The following tests were done by turning debuff 0x5 into a buff using the WepBuffEntry macro, then applying it to the iron bow.

When the enemy is unable to counter and is killed:
NoBuff

When the enemy is able to counter:
Counter

When the enemy is not killed:
Buff

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugIssues pertaining to bugs.Core FeaturesIssues pertaining to the core functions of the Skill System, its skills, or its dependencies.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions