Skip to content

Commit 8dd0e03

Browse files
committed
Update signatures of go funcs in C
1 parent 4c375ea commit 8dd0e03

File tree

2 files changed

+29
-16
lines changed

2 files changed

+29
-16
lines changed

src/nginx_module/access_phase_handler.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ struct ValidateRequestBody_return {
1515
int r0;
1616
char *r1;
1717
};
18-
typedef struct ValidateRequestBody_return (*ValidateRequestBody)(void *, int, void *, int, void *, int, void *, int,
19-
void *, int);
18+
typedef struct ValidateRequestBody_return (*ValidateRequestBody)(int, void *, int, void *, int, void *, int, void *,
19+
int);
2020

2121
typedef struct {
2222
ngx_int_t status;
@@ -150,9 +150,9 @@ static ngx_int_t FiretailClientBodyHandlerInternal(ngx_http_request_t *request)
150150
ngx_log_debug(NGX_LOG_DEBUG, request->connection->log, 0, "Validating request body...");
151151

152152
struct ValidateRequestBody_return validation_result = request_body_validator(
153-
main_config->FiretailAllowUndefinedRoutes.data, main_config->FiretailAllowUndefinedRoutes.len, ctx->request_body,
154-
ctx->request_body_size, request->unparsed_uri.data, request->unparsed_uri.len, request->method_name.data,
155-
request->method_name.len, (char *)ctx->request_headers_json, ctx->request_headers_json_size);
153+
(int)main_config->FiretailAllowUndefinedRoutes, ctx->request_body, ctx->request_body_size,
154+
request->unparsed_uri.data, request->unparsed_uri.len, request->method_name.data, request->method_name.len,
155+
(char *)ctx->request_headers_json, ctx->request_headers_json_size);
156156

157157
ngx_log_debug(NGX_LOG_DEBUG, request->connection->log, 0, "Validation request result: %d", validation_result.r0);
158158
ngx_log_debug(NGX_LOG_DEBUG, request->connection->log, 0, "Validating request body: %s", validation_result.r1);

src/nginx_module/filter_response_body.c

Lines changed: 24 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ struct ValidateResponseBody_return {
1010
int r0;
1111
char *r1;
1212
};
13-
typedef struct ValidateResponseBody_return (*ValidateResponseBody)(char *, int, char *, int, char *, int, char *, int,
14-
char *, int, void *, int, char *, int, void *, int,
15-
int, void *, int);
13+
typedef struct ValidateResponseBody_return (*ValidateResponseBody)(char *, int, char *, int, int, int, int, char *, int,
14+
char *, int, char *, int, void *, int, char *, int,
15+
int, char *, int);
1616

1717
static ngx_buf_t *FiretailResponseBodyFilterBuffer(ngx_http_request_t *request, u_char *response);
1818
static ngx_int_t FiretailResponseBodyFilterFinalise(ngx_http_request_t *request, FiretailFilterContext *ctx,
@@ -106,14 +106,27 @@ ngx_int_t FiretailResponseBodyFilter(ngx_http_request_t *request, ngx_chain_t *c
106106
ngx_log_debug(NGX_LOG_DEBUG, request->connection->log, 0, "Validating response body...");
107107

108108
FiretailConfig *main_config = ngx_http_get_module_main_conf(request, ngx_firetail_module);
109-
validation_result = response_body_validator(
110-
(char *)main_config->FiretailUrl.data, main_config->FiretailUrl.len, (char *)main_config->FiretailApiToken.data,
111-
main_config->FiretailApiToken.len, (char *)main_config->FiretailAllowUndefinedRoutes.data,
112-
(int)main_config->FiretailAllowUndefinedRoutes.len, (char *)ctx->request_body, (int)ctx->request_body_size,
113-
(char *)ctx->request_headers_json, (int)ctx->request_headers_json_size, ctx->response_body,
114-
ctx->response_body_size, response_headers_json_string, strlen(response_headers_json_string),
115-
request->unparsed_uri.data, request->unparsed_uri.len, ctx->status_code, request->method_name.data,
116-
request->method_name.len);
109+
validation_result = response_body_validator((char *)main_config->FiretailUrl.data, // urlCharPtr
110+
main_config->FiretailUrl.len, // urlLength
111+
(char *)main_config->FiretailApiToken.data, // tokenCharPtr
112+
main_config->FiretailApiToken.len, // tokenLength
113+
(int)main_config->FiretailAllowUndefinedRoutes, // allowUndefinedRoutes
114+
(int)main_config->FiretailRedactRequestBodies, // redactRequestBodies
115+
(int)main_config->FiretailRedactResponseBodies, // redactResponseBodies
116+
(char *)ctx->request_body, // reqBodyCharPtr
117+
(int)ctx->request_body_size, // reqBodyLength
118+
(char *)ctx->request_headers_json, // reqHeadersJsonCharPtr
119+
(int)ctx->request_headers_json_size, // reqHeadersJsonLength
120+
(char *)ctx->response_body, // resBodyCharPtr
121+
ctx->response_body_size, // resBodyLength
122+
response_headers_json_string, // resHeadersJsonCharPtr
123+
strlen(response_headers_json_string), // resHeadersJsonLength
124+
(char *)request->unparsed_uri.data, // pathCharPtr
125+
request->unparsed_uri.len, // pathLength
126+
ctx->status_code, // statusCode
127+
(char *)request->method_name.data, // methodCharPtr
128+
request->method_name.len // methodLength
129+
);
117130
ngx_log_debug(NGX_LOG_DEBUG, request->connection->log, 0, "Validation response result: %d", validation_result.r0);
118131
ngx_log_debug(NGX_LOG_DEBUG, request->connection->log, 0, "Validating response body: %s", validation_result.r1);
119132

0 commit comments

Comments
 (0)