Update to efcore and .net 10 #1245
Conversation
- Added translations tests for Temporal types - Applied refactorings done since EF Core 9
src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/ComplianceFbTest.cs
Outdated
Show resolved
Hide resolved
| <PackageReference Include="xunit" Version="2.9.3" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5"> |
There was a problem hiding this comment.
Exclude this. We can update it in later PR in all projects.
There was a problem hiding this comment.
This was done as the newer version of EntityFrameworkCore tests depend on 3.1.3 (runner) and 2.9.3 (xunit.core) so had to be updated to even be able to restore the packages.
So it either has to be seperated into a seperate pr which then ahs to be merged into this one, or simply like this, or I could update it directly into this pr.
...ionalTests/Query/Associations/ComplexTableSplitting/ComplexTableSplittingBulkUpdateFbTest.cs
Outdated
Show resolved
Hide resolved
...ql.EntityFrameworkCore.Firebird.FunctionalTests/Query/Translations/MathTranslationsFbTest.cs
Outdated
Show resolved
Hide resolved
...FrameworkCore.Firebird.FunctionalTests/Query/Translations/MiscellaneousTranslationsFbTest.cs
Show resolved
Hide resolved
...d.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsSetOperationsFbTest.cs
Outdated
Show resolved
Hide resolved
...unctionalTests/Query/Associations/OwnedTableSplitting/OwnedTableSplittingProjectionFbTest.cs
Outdated
Show resolved
Hide resolved
...re.Firebird.FunctionalTests/Query/Associations/OwnedNavigations/OwnedNavigationsFbFixture.cs
Outdated
Show resolved
Hide resolved
...ebird.FunctionalTests/Query/Associations/OwnedTableSplitting/OwnedTableSplittingFbFixture.cs
Show resolved
Hide resolved
...dSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindSetOperationsQueryFbTest.cs
Outdated
Show resolved
Hide resolved
|
Alright, I fixed pretty much everything now, most things which are left open, so not fixed, are done for a reason as seen in the comments. Especially all the conversion tests as explained, the casts there are really odd and not supported by firebird (bool -> numbers, and vice versa) so I disabled those with that reason. Could also re-implement those tests with a custom implementation to test the behavior we do support, but not sure if that's preferred. And the updates are left open, as those are necessary to even compile, but could be split of into a seperate PR if necessary. |
niekschoemaker
force-pushed
the
feature/efcore-10
branch
from
5c34b0e to
22e3edd
Compare
|
Test for FB3.0 seems to hang, did pass on the fork, so retrigger should fix that but can't do that myself. |
2 participants
A lot of JSON related and collections in columns tests have been disabled, as that is not supported.
Otherwise most tests are left enabled except for some specific ones, most of it due to outer joins and json related data.