Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve roundtrip tests performance #2707

Closed
mmsmits opened this issue Feb 13, 2024 · 1 comment · Fixed by #2711
Closed

Improve roundtrip tests performance #2707

mmsmits opened this issue Feb 13, 2024 · 1 comment · Fixed by #2711
Assignees

Comments

@mmsmits
Copy link
Member

mmsmits commented Feb 13, 2024

Question from @GinoCanessa

A lot of the 'long' tests are reading and writing contents to disk for all intermediate stages - are those artifacts necessary somewhere, or could we remove them?

For example, skipping the intermediate file IO on my machine takes the execution of FullRoundtripOfAllExamplesJsonNewSerializer from 4.1 minutes down to 25.3 seconds.

It would be very nice to make this faster, that would improve the duration of our build pipeline greatly.

@ewoutkramer ewoutkramer self-assigned this Feb 14, 2024
@ewoutkramer
Copy link
Member

Note: even the original FullRoundTripOfallExamplesJsonNewSerializer only took 40 seconds on my machine, so I think Gino has an anti-virus messing with his temp output directory! Even so, I'll make all of this in memory (per file ;-)) instead of using file storage as an intermediate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants