feat: Teammate Class Color can now be customized as RGB

feat: Teammate Name Overlay now compatible with Text Style
However, the Fade Chroma option has been removed. Fade Chroma is not stable because it is affected by scaling and therefore appears as an eye-straining color. Also, All The Same Chroma also works in sync with the outline color.

Author: Fix3dll

src/main/java/codes/biscuit/skyblockaddons/config/ConfigValuesManager.java

@@ -505,9 +505,11 @@ private void firstLoadChecks(Feature feature, FeatureData<?> featureData) {
                 if (!settings.containsKey(defaultSetting)) {
                     // New sub-setting entry
                     settings.put(defaultSetting, defaultValue);
+                    LOGGER.info("New '{}' FeatureSetting loaded for '{}' Feature.", defaultSetting, feature);
                 } else if (defaultValue.getClass() != settings.get(defaultSetting).getClass()) {
                     // The sub-setting value is overridden by different type
                     settings.put(defaultSetting, defaultValue);
+                    LOGGER.warn("'{}' FeatureSetting for '{}' Feature has been updated with new defaults!", defaultSetting, feature);
                 }
             }
         }

src/main/java/codes/biscuit/skyblockaddons/features/dungeon/DungeonClass.java

@@ -47,25 +47,25 @@ public static DungeonClass fromDisplayName(String name) {
         return null;
     }
 
-    public ColorCode getColor() {
+    public int getColor() {
         Feature feature = Feature.SHOW_DUNGEON_TEAMMATE_NAME_OVERLAY;
         if (feature.isEnabled()) {
             switch (this) {
                 case HEALER:
-                    return (ColorCode) feature.get(FeatureSetting.HEALER_COLOR);
+                    return feature.getAsNumber(FeatureSetting.HEALER_COLOR).intValue();
                 case MAGE:
-                    return (ColorCode) feature.get(FeatureSetting.MAGE_COLOR);
+                    return feature.getAsNumber(FeatureSetting.MAGE_COLOR).intValue();
                 case BERSERK:
-                    return (ColorCode) feature.get(FeatureSetting.BERSERK_COLOR);
+                    return feature.getAsNumber(FeatureSetting.BERSERK_COLOR).intValue();
                 case ARCHER:
-                    return (ColorCode) feature.get(FeatureSetting.ARCHER_COLOR);
+                    return feature.getAsNumber(FeatureSetting.ARCHER_COLOR).intValue();
                 case TANK:
-                    return (ColorCode) feature.get(FeatureSetting.TANK_COLOR);
+                    return feature.getAsNumber(FeatureSetting.TANK_COLOR).intValue();
                 default:
-                    return this.defaultColor;
+                    return this.defaultColor.getColor();
             }
         } else {
-            return this.defaultColor;
+            return this.defaultColor.getColor();
         }
     }
 }

src/main/java/codes/biscuit/skyblockaddons/features/dungeon/DungeonManager.java

@@ -2,6 +2,7 @@
 
 import codes.biscuit.skyblockaddons.SkyblockAddons;
 import codes.biscuit.skyblockaddons.core.EssenceType;
+import codes.biscuit.skyblockaddons.core.chroma.ManualChromaManager;
 import codes.biscuit.skyblockaddons.core.feature.Feature;
 import codes.biscuit.skyblockaddons.core.feature.FeatureSetting;
 import codes.biscuit.skyblockaddons.events.RenderEntityOutlineEvent;
@@ -106,8 +107,8 @@ public class DungeonManager {
         if (e instanceof EntityOtherPlayerMP) {
             String profileName = ((EntityOtherPlayerMP) e).getGameProfile().getName();
             DungeonPlayer teammate = SkyblockAddons.getInstance().getDungeonManager().getDungeonPlayerByName(profileName);
-            if (teammate != null) {
-                return teammate.getDungeonClass().getColor().getColor();
+            if (teammate != null && teammate.getDungeonClass() != null) {
+                return teammate.getDungeonClass().getColor();
             }
             // NPCs don't have a color on their team. Don't show them on outlines.
             return null;
@@ -385,17 +386,18 @@ public void onRenderLivingName(RenderLivingEvent.Specials.Pre<EntityLivingBase>
             return;
         }
 
-        if (main.getUtils().isOnSkyblock() && main.getUtils().isInDungeon()
-                && (Feature.SHOW_CRITICAL_DUNGEONS_TEAMMATES.isEnabled() || Feature.SHOW_DUNGEON_TEAMMATE_NAME_OVERLAY.isEnabled())
-        ) {
+        boolean nameOverlayEnabled = Feature.SHOW_DUNGEON_TEAMMATE_NAME_OVERLAY.isEnabled();
+        boolean criticalOverlayEnabled = Feature.SHOW_CRITICAL_DUNGEONS_TEAMMATES.isEnabled();
+
+        if (main.getUtils().isOnSkyblock() && main.getUtils().isInDungeon() && (criticalOverlayEnabled || nameOverlayEnabled)) {
             final Entity renderViewEntity = MC.getRenderViewEntity();
             String profileName = player.getName();
             DungeonPlayer dungeonPlayer = main.getDungeonManager().getTeammates().getOrDefault(profileName, null);
 
             if (renderViewEntity != player && dungeonPlayer != null) {
                 double newY = e.y + player.height;
 
-                if (Feature.SHOW_DUNGEON_TEAMMATE_NAME_OVERLAY.isEnabled()) {
+                if (nameOverlayEnabled) {
                     newY += 0.35F;
                 }
 
@@ -422,7 +424,7 @@ public void onRenderLivingName(RenderLivingEvent.Specials.Pre<EntityLivingBase>
                 GlStateManager.enableTexture2D();
                 GlStateManager.color(1, 1, 1, 1);
 
-                if (Feature.SHOW_CRITICAL_DUNGEONS_TEAMMATES.isEnabled() && !dungeonPlayer.isGhost()
+                if (criticalOverlayEnabled && !dungeonPlayer.isGhost()
                         && (dungeonPlayer.isCritical() || dungeonPlayer.isLow())) {
                     MC.getTextureManager().bindTexture(CRITICAL);
                     DrawUtils.drawModalRectWithCustomSizedTexture(-CRITICAL_ICON_SIZE / 2F, -CRITICAL_ICON_SIZE, 0, 0, CRITICAL_ICON_SIZE, CRITICAL_ICON_SIZE, CRITICAL_ICON_SIZE, CRITICAL_ICON_SIZE);
@@ -448,16 +450,22 @@ public void onRenderLivingName(RenderLivingEvent.Specials.Pre<EntityLivingBase>
                     e.setCanceled(true);
                 }
 
-                if (!dungeonPlayer.isGhost() && Feature.SHOW_DUNGEON_TEAMMATE_NAME_OVERLAY.isEnabled()) {
-                    String nameOverlay =
-                            ColorCode.YELLOW + "[" + dungeonPlayer.getDungeonClass().getFirstLetter() + "] "
-                                    + dungeonPlayer.getDungeonClass().getColor() + profileName;
-                    MC.fontRendererObj.drawString(
-                            nameOverlay,
-                            -MC.fontRendererObj.getStringWidth(nameOverlay) / 2F,
-                            CRITICAL_ICON_SIZE / 2F + 2,
-                            -1,
-                            true
+                if (!dungeonPlayer.isGhost() && dungeonPlayer.getDungeonClass() != null && nameOverlayEnabled) {
+                    String dungeonClass = ColorCode.YELLOW + "[" + dungeonPlayer.getDungeonClass().getFirstLetter() + "] ";
+                    float nameX = MC.fontRendererObj.getStringWidth(dungeonClass.concat(profileName)) / 2F;
+                    float nameY = CRITICAL_ICON_SIZE / 2F + 2;
+
+                    DrawUtils.drawText(dungeonClass, -nameX, nameY, -1);
+
+                    int classColor = dungeonPlayer.getDungeonClass().getColor();
+                    if (classColor == ColorCode.CHROMA.getColor()) {
+                       classColor = ManualChromaManager.getChromaColor(0, 0, 255);
+                    }
+                    DrawUtils.drawText(
+                            profileName,
+                            -nameX + MC.fontRendererObj.getStringWidth(dungeonClass),
+                            nameY,
+                            classColor
                     );
 
                     String health = dungeonPlayer.getHealth() + (ColorCode.RED + "❤");

src/main/resources/defaults.json

@@ -594,11 +594,11 @@
     "value": true,
     "settings": {
       "CLASS_COLORED_TEAMMATE": true,
-      "HEALER_COLOR": "LIGHT_PURPLE",
-      "MAGE_COLOR": "AQUA",
-      "BERSERK_COLOR": "DARK_RED",
-      "ARCHER_COLOR": "GOLD",
-      "TANK_COLOR": "DARK_GREEN"
+      "HEALER_COLOR": -43521,
+      "MAGE_COLOR": -11141121,
+      "BERSERK_COLOR": -5636096,
+      "ARCHER_COLOR": -22016,
+      "TANK_COLOR": -16733696
     }
   },
   "SHOW_STACKING_ENCHANT_PROGRESS": {