From 280cb3720fb227eeb839869b128db5d12a50c78e Mon Sep 17 00:00:00 2001 From: Sam Eriksen Date: Tue, 1 Jul 2025 10:43:57 +0200 Subject: [PATCH 1/3] fix: get_median_disc_asymptotic to pass sigma_level --- flamedisx/non_asymptotic_inference.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flamedisx/non_asymptotic_inference.py b/flamedisx/non_asymptotic_inference.py index ea916968..405fb687 100644 --- a/flamedisx/non_asymptotic_inference.py +++ b/flamedisx/non_asymptotic_inference.py @@ -788,7 +788,7 @@ def get_median_disco_asymptotic(self, sigma_level=3): disco_sig_curves = np.stack(disco_sig_curves, axis=0) median_disco_sigs = [np.median(disco_sigs) for disco_sigs in disco_sig_curves] - median_crossing_point = self.critical_disco_value(median_disco_sigs, mus, 3) + median_crossing_point = self.critical_disco_value(median_disco_sigs, mus, sigma_level) medians[signal_source] = median_crossing_point return medians From 9e8458263bf2f3747d27e120e52761d81af2a493 Mon Sep 17 00:00:00 2001 From: Sam Eriksen Date: Tue, 1 Jul 2025 10:55:09 +0200 Subject: [PATCH 2/3] debug: adding print statements whilst debugging --- flamedisx/non_asymptotic_inference.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/flamedisx/non_asymptotic_inference.py b/flamedisx/non_asymptotic_inference.py index 405fb687..214b4b84 100644 --- a/flamedisx/non_asymptotic_inference.py +++ b/flamedisx/non_asymptotic_inference.py @@ -787,7 +787,9 @@ def get_median_disco_asymptotic(self, sigma_level=3): disco_sig_curves = np.stack(disco_sig_curves, axis=0) median_disco_sigs = [np.median(disco_sigs) for disco_sigs in disco_sig_curves] - + print("median_disco_sigs") + print(median_disco_sigs) + print(f"sigma_level: {sigma_level}") median_crossing_point = self.critical_disco_value(median_disco_sigs, mus, sigma_level) medians[signal_source] = median_crossing_point From 35c8243dd9452aee7bc0c49c43a8598388c094e0 Mon Sep 17 00:00:00 2001 From: Sam Eriksen Date: Tue, 25 Nov 2025 11:39:00 +0000 Subject: [PATCH 3/3] chore: remove debug prints from non_asymptotic_inference.py Removed debug print statements for median disco signals. --- flamedisx/non_asymptotic_inference.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/flamedisx/non_asymptotic_inference.py b/flamedisx/non_asymptotic_inference.py index 214b4b84..e3ace9bb 100644 --- a/flamedisx/non_asymptotic_inference.py +++ b/flamedisx/non_asymptotic_inference.py @@ -787,9 +787,6 @@ def get_median_disco_asymptotic(self, sigma_level=3): disco_sig_curves = np.stack(disco_sig_curves, axis=0) median_disco_sigs = [np.median(disco_sigs) for disco_sigs in disco_sig_curves] - print("median_disco_sigs") - print(median_disco_sigs) - print(f"sigma_level: {sigma_level}") median_crossing_point = self.critical_disco_value(median_disco_sigs, mus, sigma_level) medians[signal_source] = median_crossing_point