Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Integration Test on CI for Windows #278

Open
perfectmak opened this issue Dec 9, 2020 · 0 comments
Open

Fix Broken Integration Test on CI for Windows #278

perfectmak opened this issue Dec 9, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@perfectmak
Copy link
Contributor

Expected Behaviour

Github Actions should run existing integration tests successfully on windows-latest machine

Actual Behaviour

Integrations tests run on the windows-latest operating systems are failing.

Extra Information

Here is a CI run that failed: https://github.com/FleekHQ/space-daemon/runs/1524767049?check_suite_focus=true

The issue appears to be with a wrong Ipfsnodepath being passed to the ipfs node started in the integration suites BeforeSuite lifecycle.

Possible Fixes:

  • Investigate why the path expansion by the ipfs library works differently from mac and linux
  • or start an ipfs node in the github workflows service and update the flags set in GetConfig() to point to this new ipfs node.
@perfectmak perfectmak added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant