Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy for a Xiana app to turn off logging messages #282

Closed
soulflyer opened this issue Feb 15, 2024 · 4 comments · Fixed by #284
Closed

Make it easy for a Xiana app to turn off logging messages #282

soulflyer opened this issue Feb 15, 2024 · 4 comments · Fixed by #284
Assignees

Comments

@soulflyer
Copy link
Contributor

Xiana is "noisy" in apps built using it. It should be easy to turn this off, as we use timbre which can set logging levels. It looks like control of this level is set inside the xiana code but it should be set in the app.

@soulflyer
Copy link
Contributor Author

Ugh. Looks like we are using both Timbre and Clojure.tools.logging. Should remove one before completing this.

@jiriknesl
Copy link

We should absolutely use just 1. Which one do we use more?

@soulflyer
Copy link
Contributor Author

Actually we only use Timbre, but we are seeing logging from included libraries via clojure.tools.logging. We can arrange for both to be controlled from the config.

@gmsvalente
Copy link
Contributor

  • create a function that runs at system config time to set timbre log level

@gmsvalente gmsvalente linked a pull request Feb 29, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants