[CCE] Resource flexibleengine_cce_pvc import always returns OK

[azrod]

In resource flexibleengine_cce_pvc import always returns OK

This bug is in HuaweiCloud Importer function for cce_vpc (Ref). This function call GetCcePvcInfoById func (Ref).

func GetCcePvcInfoById(c *golangsdk.ServiceClient, clusterId, namespace,
	id string) (*persistentvolumeclaims.PersistentVolumeClaim, error) {
	pages, err := persistentvolumeclaims.List(c, clusterId, namespace).AllPages()
	if err != nil {
		return nil, err
	}
	responses, err := persistentvolumeclaims.ExtractPersistentVolumeClaims(pages)
	if err != nil {
		return nil, err
	}
	for _, v := range responses {
		if v.Metadata.UID == id {
			return &v, nil
		}
	}
	// PVC has not exist.
	return nil, nil
}

This function always return nil,nil if PVC has not exist. And in func resourceCcePvcResourceImportState if GetCcePvcInfoById return nil,nil no error is returned

	resp, err := GetCcePvcInfoById(c, clsuterId, namespace, parts[2])
	if err != nil {
		return []*schema.ResourceData{d}, err
	}
	d.SetId(resp.Metadata.UID)
	d.Set("cluster_id", parts[0])
	d.Set("namespace", parts[1])

	return []*schema.ResourceData{d}, nil

Result the resource is always imported even if it does not exist

References

• Issue in Crossplane flexibleengine provider

[azrod]

Track PR in terraform-huaweicloud-provider