Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some recipes don`t work #10

Open
MrTransistorsChannel opened this issue Aug 8, 2021 · 3 comments
Open

Some recipes don`t work #10

MrTransistorsChannel opened this issue Aug 8, 2021 · 3 comments

Comments

@MrTransistorsChannel
Copy link
Collaborator

A well-known issue, added this just to collect info about wanted recipes

Currently working on a way to bring custom recipes to the plugin

@MrTransistorsChannel
Copy link
Collaborator Author

Currently known:

  1. Firework rockets (problem with duration, the recipe has to be overwritten)
  2. Shulker box dyeing (has to be added preserving the NBT)
  3. Banner+shield (may be hard to implement because we will need to copy the NBT from the banner to the shield properly)

@MrTransistorsChannel
Copy link
Collaborator Author

MrTransistorsChannel commented Aug 9, 2021

@Fliens the reason I didn't include avixk's version of this fix is because his code doesn't keep the NBT of a shulker box (so like name, contents...) and I didn't want people to loose their items because of this dirty fix

@MrTransistorsChannel MrTransistorsChannel linked a pull request Aug 9, 2021 that will close this issue
@MrTransistorsChannel
Copy link
Collaborator Author

MrTransistorsChannel commented Aug 9, 2021

#11 will fix firework rockets. Shulker boxes are coming next.

Also found out that you can`t craft firework stars and starred fireworks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant