Skip to content

Commit 53f3d00

Browse files
authored
Merge pull request #4542 from FlowFuse/4467_friendlier-error-messages-on-file-asset-service
improved alert notification messages on asset service file/folder upload
2 parents f450630 + abbe6c0 commit 53f3d00

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

frontend/src/components/file-browser/FileBrowser.vue

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,7 @@ export default {
254254
this.loading = true
255255
AssetsAPI.createFolder(this.instanceId, this.baseURI, this.forms.newFolder.name)
256256
.then(() => this.$emit('items-updated'))
257-
.catch(error => {
258-
console.error(error)
259-
Alerts.emit(error.response.data.error, 'warning')
260-
})
257+
.catch(() => Alerts.emit(`Unable to create folder with name '${this.forms.newFolder.name}'`, 'warning'))
261258
.finally(() => {
262259
this.forms.newFolder.name = ''
263260
this.loading = false
@@ -278,10 +275,7 @@ export default {
278275
this.forms.newFolder = { name: '' }
279276
this.$emit('items-updated')
280277
})
281-
.catch(error => {
282-
console.error(error)
283-
Alerts.emit(error.response.data.error, 'warning')
284-
})
278+
.catch(() => Alerts.emit(`Unable to update folder name to '${this.forms.newFolder.name}'`, 'warning'))
285279
.finally(() => {
286280
this.loading = false
287281
})
@@ -332,10 +326,7 @@ export default {
332326
this.loading = true
333327
AssetsAPI.uploadFile(this.instanceId, pwd, filename, this.forms.file)
334328
.then(() => this.$emit('items-updated'))
335-
.catch(error => {
336-
console.error(error)
337-
Alerts.emit(error.response.data.error, 'warning')
338-
})
329+
.catch(() => Alerts.emit('Unable to upload file', 'warning'))
339330
.finally(() => {
340331
this.forms.file = null
341332
this.$refs.fileUpload.clear()

0 commit comments

Comments
 (0)