From 297eb1bda601fd5cec5212a39bf2c0b53a1c790a Mon Sep 17 00:00:00 2001
From: cstns <cstn.serban@gmail.com>
Date: Fri, 12 Jul 2024 11:29:26 +0300
Subject: [PATCH 01/15] carry the search query through the applications
 component and pass it to the applicationDevices & applicationInstances routes

---
 .../Applications/components/Application.vue   | 10 ++---
 .../components/compact/DevicesWrapper.vue     | 30 ++++++-------
 .../components/compact/HasMoreTile.vue        | 43 +++++++++++++++++++
 .../components/compact/InstancesWrapper.vue   | 31 ++++++-------
 .../src/pages/team/Applications/index.vue     |  2 +-
 5 files changed, 80 insertions(+), 36 deletions(-)
 create mode 100644 frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue

diff --git a/frontend/src/pages/team/Applications/components/Application.vue b/frontend/src/pages/team/Applications/components/Application.vue
index 16a63be1f8..1a71109cb9 100644
--- a/frontend/src/pages/team/Applications/components/Application.vue
+++ b/frontend/src/pages/team/Applications/components/Application.vue
@@ -1,9 +1,9 @@
 <template>
     <ApplicationHeader :application="localApplication" />
 
-    <InstancesWrapper :application="localApplication" :is-searching="isSearching" @delete-instance="onInstanceDelete" />
+    <InstancesWrapper :application="localApplication" :search-query="searchQuery" @delete-instance="onInstanceDelete" />
 
-    <DevicesWrapper :application="localApplication" :is-searching="isSearching" @delete-device="$emit('device-deleted')" />
+    <DevicesWrapper :application="localApplication" :search-query="searchQuery" @delete-device="$emit('device-deleted')" />
 
     <ConfirmInstanceDeleteDialog ref="confirmInstanceDeleteDialog" @confirm="onInstanceDeleted" />
 </template>
@@ -29,10 +29,10 @@ export default {
             type: Object,
             required: true
         },
-        isSearching: {
-            type: Boolean,
+        searchQuery: {
+            type: String,
             required: false,
-            default: false
+            default: ''
         }
     },
     emits: ['instance-deleted', 'device-deleted'],
diff --git a/frontend/src/pages/team/Applications/components/compact/DevicesWrapper.vue b/frontend/src/pages/team/Applications/components/compact/DevicesWrapper.vue
index 742d2f7e7a..faade7332b 100644
--- a/frontend/src/pages/team/Applications/components/compact/DevicesWrapper.vue
+++ b/frontend/src/pages/team/Applications/components/compact/DevicesWrapper.vue
@@ -27,15 +27,13 @@
             >
                 <DeviceTile :device="device" :application="application" @device-action="onDeviceAction" />
             </div>
-            <div v-if="hasMoreDevices" class="has-more item-wrapper">
-                <router-link :to="{name: 'ApplicationDevices', params: {id: application.id}}">
-                    <span>
-                        {{ remainingDevices }}
-                        More...
-                    </span>
-                    <ChevronRightIcon class="ff-icon" />
-                </router-link>
-            </div>
+            <HasMoreTile
+                v-if="hasMoreDevices"
+                link-to="ApplicationDevices"
+                :remaining="remainingDevices"
+                :application="application"
+                :search-query="searchQuery"
+            />
         </div>
 
         <TeamDeviceCreateDialog
@@ -71,18 +69,17 @@
 </template>
 
 <script>
-import { ChevronRightIcon } from '@heroicons/vue/solid'
-
 import IconDeviceSolid from '../../../../../components/icons/DeviceSolid.js'
 import deviceActionsMixin from '../../../../../mixins/DeviceActions.js'
 import DeviceCredentialsDialog from '../../../Devices/dialogs/DeviceCredentialsDialog.vue'
 import TeamDeviceCreateDialog from '../../../Devices/dialogs/TeamDeviceCreateDialog.vue'
 
 import DeviceTile from './DeviceTile.vue'
+import HasMoreTile from './HasMoreTile.vue'
 
 export default {
     name: 'DevicesWrapper',
-    components: { TeamDeviceCreateDialog, DeviceCredentialsDialog, ChevronRightIcon, IconDeviceSolid, DeviceTile },
+    components: { HasMoreTile, TeamDeviceCreateDialog, DeviceCredentialsDialog, IconDeviceSolid, DeviceTile },
     mixins: [deviceActionsMixin],
     props: {
         application: {
@@ -90,10 +87,10 @@ export default {
             required: true,
             default: null
         },
-        isSearching: {
-            type: Boolean,
+        searchQuery: {
+            type: String,
             required: false,
-            default: false
+            default: ''
         }
     },
     emits: ['delete-device'],
@@ -120,6 +117,9 @@ export default {
         },
         devices () {
             return this.application.devices.slice(0, 3)
+        },
+        isSearching () {
+            return this.searchQuery.length > 0
         }
     },
     mounted () {
diff --git a/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue b/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
new file mode 100644
index 0000000000..6d20696384
--- /dev/null
+++ b/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
@@ -0,0 +1,43 @@
+<template>
+    <div class="has-more item-wrapper">
+        <router-link :to="{name: linkTo, params: {id: application.id, searchQuery: searchQuery}}">
+            <span>
+                {{ remaining }}
+                More...
+            </span>
+            <ChevronRightIcon class="ff-icon" />
+        </router-link>
+    </div>
+</template>
+
+<script>
+import { ChevronRightIcon } from '@heroicons/vue/solid'
+
+export default {
+    name: 'HasMoreTile',
+    components: { ChevronRightIcon },
+    props: {
+        application: {
+            type: Object,
+            required: true
+        },
+        remaining: {
+            type: Number,
+            required: true
+        },
+        linkTo: {
+            type: String,
+            required: true
+        },
+        searchQuery: {
+            type: String,
+            required: false,
+            default: ''
+        }
+    }
+}
+</script>
+
+<style scoped lang="scss">
+
+</style>
diff --git a/frontend/src/pages/team/Applications/components/compact/InstancesWrapper.vue b/frontend/src/pages/team/Applications/components/compact/InstancesWrapper.vue
index 430b75b68c..4a3046ae6e 100644
--- a/frontend/src/pages/team/Applications/components/compact/InstancesWrapper.vue
+++ b/frontend/src/pages/team/Applications/components/compact/InstancesWrapper.vue
@@ -27,39 +27,37 @@
             >
                 <InstanceTile :instance="instance" @delete-instance="$emit('delete-instance', $event)" />
             </div>
-            <div v-if="hasMoreInstances" class="has-more item-wrapper">
-                <router-link :to="{name: 'ApplicationInstances', params: {id: application.id}}">
-                    <span>
-                        {{ remainingInstances }}
-                        More...
-                    </span>
-                    <ChevronRightIcon class="ff-icon" />
-                </router-link>
-            </div>
+            <HasMoreTile
+                v-if="hasMoreInstances"
+                link-to="ApplicationInstances"
+                :remaining="remainingInstances"
+                :application="application"
+                :search-query="searchQuery"
+            />
         </div>
     </section>
 </template>
 
 <script>
-import { ChevronRightIcon } from '@heroicons/vue/solid'
-
 import IconNodeRedSolid from '../../../../../components/icons/NodeRedSolid.js'
 
+import HasMoreTile from './HasMoreTile.vue'
+
 import InstanceTile from './InstanceTile.vue'
 
 export default {
     name: 'InstancesWrapper',
-    components: { ChevronRightIcon, IconNodeRedSolid, InstanceTile },
+    components: { HasMoreTile, IconNodeRedSolid, InstanceTile },
     props: {
         application: {
             type: Object,
             required: true,
             default: null
         },
-        isSearching: {
-            type: Boolean,
+        searchQuery: {
+            type: String,
             required: false,
-            default: false
+            default: ''
         }
     },
     emits: ['delete-instance'],
@@ -86,6 +84,9 @@ export default {
         },
         threeInstances () {
             return this.application.instanceCount === 3
+        },
+        isSearching () {
+            return this.searchQuery.length > 0
         }
     }
 }
diff --git a/frontend/src/pages/team/Applications/index.vue b/frontend/src/pages/team/Applications/index.vue
index 69d80fc66b..072ecc2c3a 100644
--- a/frontend/src/pages/team/Applications/index.vue
+++ b/frontend/src/pages/team/Applications/index.vue
@@ -48,7 +48,7 @@
                     <li v-for="application in filteredApplications" :key="application.id" data-el="application-item">
                         <ApplicationListItem
                             :application="application"
-                            :is-searching="filterTerm.length > 0"
+                            :search-query="filterTerm"
                             @instance-deleted="fetchData(false)"
                             @device-deleted="fetchData(false)"
                         />

From 9331c6a206bc271e3d8872b5de9918af9e77c70a Mon Sep 17 00:00:00 2001
From: cstns <cstn.serban@gmail.com>
Date: Fri, 12 Jul 2024 11:56:35 +0300
Subject: [PATCH 02/15] qf pass search query as query not param

---
 .../pages/team/Applications/components/compact/HasMoreTile.vue  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue b/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
index 6d20696384..ab0cbc325c 100644
--- a/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
+++ b/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
@@ -1,6 +1,6 @@
 <template>
     <div class="has-more item-wrapper">
-        <router-link :to="{name: linkTo, params: {id: application.id, searchQuery: searchQuery}}">
+        <router-link :to="{name: linkTo, params: {id: application.id}, query: {searchQuery}}">
             <span>
                 {{ remaining }}
                 More...

From 6fb5fd571ad82efe0e6d7fa6929a3fe7c54c14df Mon Sep 17 00:00:00 2001
From: cstns <cstn.serban@gmail.com>
Date: Fri, 12 Jul 2024 12:07:35 +0300
Subject: [PATCH 03/15] Making the datatable react to search query arguments to
 update its internal search

---
 .../src/ui-components/components/data-table/DataTable.vue  | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/frontend/src/ui-components/components/data-table/DataTable.vue b/frontend/src/ui-components/components/data-table/DataTable.vue
index 7069675945..6a9d59e83a 100644
--- a/frontend/src/ui-components/components/data-table/DataTable.vue
+++ b/frontend/src/ui-components/components/data-table/DataTable.vue
@@ -194,7 +194,7 @@ export default {
         },
         filterTerm: {
             get () {
-                return this.search
+                return this.search || this.internalSearch
             },
             set (value) {
                 const valueChanged = value !== this.internalSearch
@@ -259,6 +259,11 @@ export default {
             }
         }
     },
+    mounted () {
+        if (this.$route?.query?.searchQuery) {
+            this.internalSearch = this.$route.query.searchQuery
+        }
+    },
     methods: {
         filterRows (rows) {
             const search = this.internalSearch

From 4f84e8b0cf8789388c6354eb84a8423727521d66 Mon Sep 17 00:00:00 2001
From: cstns <cstn.serban@gmail.com>
Date: Fri, 12 Jul 2024 14:20:06 +0300
Subject: [PATCH 04/15] carry on search terms to applications instances page

---
 frontend/src/pages/application/Overview.vue | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/frontend/src/pages/application/Overview.vue b/frontend/src/pages/application/Overview.vue
index 20f1fc7451..d693647ef2 100644
--- a/frontend/src/pages/application/Overview.vue
+++ b/frontend/src/pages/application/Overview.vue
@@ -28,6 +28,7 @@
                 :columns="cloudColumns"
                 :rows="filteredRows"
                 :show-search="true"
+                :search="searchTerm"
                 search-placeholder="Search Instances"
                 :rows-selectable="true"
                 @update:search="updateSearch"
@@ -174,6 +175,11 @@ export default {
             return this.teamMembership.role === Roles.Admin
         }
     },
+    mounted () {
+        if (this.$route?.query?.searchQuery) {
+            this.searchTerm = this.$route.query.searchQuery
+        }
+    },
     methods: {
         selectedCloudRow (cloudInstance) {
             this.$router.push({

From cb21e89b191e0d93c91a61477955556480ce6a73 Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:16:51 +0200
Subject: [PATCH 05/15] Add notification to `Install test` pipeline

---
 .github/workflows/install-test.yaml | 49 +++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index caa6d1bd68..0c05119274 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -7,6 +7,7 @@ on:
 
 jobs:
   install:
+    name: Install and test
     runs-on: ubuntu-latest
     steps:
       - uses: actions/setup-node@v4
@@ -32,3 +33,51 @@ jobs:
       - name: test access
         run: |
           curl -L -v http://localhost:3000
+
+  notify-slack:
+    name: Notify about test failure
+    needs: [install]
+    if: failure()
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: Post to a Slack channel
+      id: slack
+      uses: slackapi/slack-github-action@v1.26.0
+      with:
+        channel-id: 'C03AP45RSFP'
+        payload: |
+          {
+            "blocks": [
+              {
+                "type": "header",
+                "text": {
+                  "type": "plain_text",
+                  "text": ":fire: Install Test workflow failed",
+                  "emoji": true
+                }
+              },
+              {
+                "type": "divider"
+              },
+              {
+                "type": "section",
+                "fields": [
+                  {
+                    "type": "mrkdwn",
+                    "text": "*Status:*\n$':x: Failure '
+                  },
+                  {
+                    "type": "mrkdwn",
+                    "text": "`${{ github.workflow.name }}` failed to complete successfully."
+                  },
+                  {
+                    "type": "mrkdwn",
+                    "text": "*Workflow run:*\n<${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View>"
+                  }
+                ]
+              }
+            ]
+          }
+      env:
+        SLACK_BOT_TOKEN: ${{ secrets.SLACK_GHBOT_TOKEN }}

From 5d040a04d67ab64943453bac8d56e18632785ecd Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:22:42 +0200
Subject: [PATCH 06/15] Simulate failure

---
 .github/workflows/install-test.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index 0c05119274..7ea7d28e63 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -33,6 +33,10 @@ jobs:
       - name: test access
         run: |
           curl -L -v http://localhost:3000
+      - name: simulate the error
+        run: |
+          echo "This is the error"
+          exit 1
 
   notify-slack:
     name: Notify about test failure

From aacbcb427875e8f7e447b15d644a956a555c09c7 Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:25:46 +0200
Subject: [PATCH 07/15] Fix slack payload

---
 .github/workflows/install-test.yaml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index 7ea7d28e63..633aa79ed1 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -67,10 +67,6 @@ jobs:
               {
                 "type": "section",
                 "fields": [
-                  {
-                    "type": "mrkdwn",
-                    "text": "*Status:*\n$':x: Failure '
-                  },
                   {
                     "type": "mrkdwn",
                     "text": "`${{ github.workflow.name }}` failed to complete successfully."

From 81ae063f753f61170329668dcbaa6cff6658699c Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:28:37 +0200
Subject: [PATCH 08/15] Test variables in payload

---
 .github/workflows/install-test.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index 633aa79ed1..6f1a78f50a 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -3,6 +3,7 @@ on:
   schedule:
     - cron: '45 23 * * *'
   workflow_dispatch:
+  push:
 
 
 jobs:
@@ -57,7 +58,7 @@ jobs:
                 "type": "header",
                 "text": {
                   "type": "plain_text",
-                  "text": ":fire: Install Test workflow failed",
+                  "text": ":x: ${{ github.workflow.name }} workflow failed",
                   "emoji": true
                 }
               },
@@ -69,7 +70,7 @@ jobs:
                 "fields": [
                   {
                     "type": "mrkdwn",
-                    "text": "`${{ github.workflow.name }}` failed to complete successfully."
+                    "text": "${{ github.workflow.name }} failed to complete successfully."
                   },
                   {
                     "type": "mrkdwn",

From 1747fa5c75c991f334526454ada6edc76756f860 Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:29:53 +0200
Subject: [PATCH 09/15] Fix dynamic workflow name

---
 .github/workflows/install-test.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index 6f1a78f50a..f620674382 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -58,7 +58,7 @@ jobs:
                 "type": "header",
                 "text": {
                   "type": "plain_text",
-                  "text": ":x: ${{ github.workflow.name }} workflow failed",
+                  "text": ":x: ${{ github.workflow }} workflow failed",
                   "emoji": true
                 }
               },
@@ -70,7 +70,7 @@ jobs:
                 "fields": [
                   {
                     "type": "mrkdwn",
-                    "text": "${{ github.workflow.name }} failed to complete successfully."
+                    "text": "${{ github.workflow }} failed to complete successfully."
                   },
                   {
                     "type": "mrkdwn",

From 8d9b8c2668d8140c465734108ad79b0e10e44d14 Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:32:24 +0200
Subject: [PATCH 10/15] Message formatting

---
 .github/workflows/install-test.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index f620674382..b1edfa576c 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -70,7 +70,11 @@ jobs:
                 "fields": [
                   {
                     "type": "mrkdwn",
-                    "text": "${{ github.workflow }} failed to complete successfully."
+                    "text": "`${{ github.workflow }}` workflow failed to complete successfully."
+                  },
+                  {
+                    "type": "mrkdwn",
+                    "text": "",
                   },
                   {
                     "type": "mrkdwn",

From d64b8e85a1154420fc45e93a0c9ec657540b525f Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:39:31 +0200
Subject: [PATCH 11/15] Message formatting

---
 .github/workflows/install-test.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index b1edfa576c..5b6b7dc0c0 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -74,7 +74,7 @@ jobs:
                   },
                   {
                     "type": "mrkdwn",
-                    "text": "",
+                    "text": " ",
                   },
                   {
                     "type": "mrkdwn",

From ca29690bf918fa3bc9e14c4968694bdd981666ca Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:50:31 +0200
Subject: [PATCH 12/15] Redesign message body

---
 .github/workflows/install-test.yaml | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index 5b6b7dc0c0..6ab7144805 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -67,20 +67,17 @@ jobs:
               },
               {
                 "type": "section",
-                "fields": [
-                  {
-                    "type": "mrkdwn",
-                    "text": "`${{ github.workflow }}` workflow failed to complete successfully."
-                  },
-                  {
-                    "type": "mrkdwn",
-                    "text": " ",
-                  },
-                  {
-                    "type": "mrkdwn",
-                    "text": "*Workflow run:*\n<${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View>"
-                  }
-                ]
+                "text": {
+                  "type": "mrkdwn",
+                  "text": "<${{ github.server_url }}/${{ github.repository }}/actions/workflows/install-test.yaml|${{ github.workflow }}>` workflow failed to complete successfully."
+                }
+              },
+              {
+                "type": "section",
+                "text": {
+                  "type": "mrkdwn",
+                  "text": "*Workflow run:*\n<${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|View>"
+                }
               }
             ]
           }

From 9968a4a850616f34f1d85773a613198623bce773 Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:52:10 +0200
Subject: [PATCH 13/15] Message formatting

---
 .github/workflows/install-test.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index 6ab7144805..8212be8785 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -69,7 +69,7 @@ jobs:
                 "type": "section",
                 "text": {
                   "type": "mrkdwn",
-                  "text": "<${{ github.server_url }}/${{ github.repository }}/actions/workflows/install-test.yaml|${{ github.workflow }}>` workflow failed to complete successfully."
+                  "text": "<${{ github.server_url }}/${{ github.repository }}/actions/workflows/install-test.yaml|${{ github.workflow }}> workflow failed to complete successfully."
                 }
               },
               {

From ac38a1a6e2074a8bb83b18e35d455f2160cdfc4f Mon Sep 17 00:00:00 2001
From: ppawlowski <piotr@devopswizards.com>
Date: Mon, 15 Jul 2024 11:54:17 +0200
Subject: [PATCH 14/15] Prepare for a review

---
 .github/workflows/install-test.yaml | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/.github/workflows/install-test.yaml b/.github/workflows/install-test.yaml
index 8212be8785..30cc9f9abd 100644
--- a/.github/workflows/install-test.yaml
+++ b/.github/workflows/install-test.yaml
@@ -3,8 +3,6 @@ on:
   schedule:
     - cron: '45 23 * * *'
   workflow_dispatch:
-  push:
-
 
 jobs:
   install:
@@ -34,10 +32,6 @@ jobs:
       - name: test access
         run: |
           curl -L -v http://localhost:3000
-      - name: simulate the error
-        run: |
-          echo "This is the error"
-          exit 1
 
   notify-slack:
     name: Notify about test failure
@@ -50,7 +44,7 @@ jobs:
       id: slack
       uses: slackapi/slack-github-action@v1.26.0
       with:
-        channel-id: 'C03AP45RSFP'
+        channel-id: 'C067BD0377F'
         payload: |
           {
             "blocks": [

From 35944ff499c33851a725a0af8648c8682a1f48ea Mon Sep 17 00:00:00 2001
From: cstns <cstn.serban@gmail.com>
Date: Mon, 15 Jul 2024 14:39:13 +0300
Subject: [PATCH 15/15] adding e2e tests

---
 .../components/compact/HasMoreTile.vue        |   2 +-
 .../tests/applications/overview.spec.js       | 285 +++++++++++++++++-
 2 files changed, 277 insertions(+), 10 deletions(-)

diff --git a/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue b/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
index ab0cbc325c..d19a936b0c 100644
--- a/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
+++ b/frontend/src/pages/team/Applications/components/compact/HasMoreTile.vue
@@ -1,5 +1,5 @@
 <template>
-    <div class="has-more item-wrapper">
+    <div class="has-more item-wrapper" data-el="has-more-tile">
         <router-link :to="{name: linkTo, params: {id: application.id}, query: {searchQuery}}">
             <span>
                 {{ remaining }}
diff --git a/test/e2e/frontend/cypress/tests/applications/overview.spec.js b/test/e2e/frontend/cypress/tests/applications/overview.spec.js
index 827cf5db53..e0b89903e3 100644
--- a/test/e2e/frontend/cypress/tests/applications/overview.spec.js
+++ b/test/e2e/frontend/cypress/tests/applications/overview.spec.js
@@ -837,16 +837,283 @@ describe('FlowForge - Applications', () => {
                         cy.get('[data-el="application-instance-item"]').should('have.length', 1)
                         cy.get('[data-el="application-instance-item"]').contains('interesting instance name')
                     })
+            })
+
+            it('carries the search queries onwards to the application devices page when clicking show more', () => {
+                const devices = [
+                    {
+                        id: '1',
+                        name: 'common device name',
+                        lastSeenAt: null,
+                        lastSeenMs: null,
+                        status: 'offline',
+                        mode: 'autonomous',
+                        isDeploying: false
+                    },
+                    {
+                        id: '2',
+                        name: 'not so common device name',
+                        lastSeenAt: null,
+                        lastSeenMs: null,
+                        status: 'offline',
+                        mode: 'autonomous',
+                        isDeploying: false
+                    },
+                    {
+                        id: '3',
+                        name: 'xyz device name with common element',
+                        lastSeenAt: null,
+                        lastSeenMs: null,
+                        status: 'offline',
+                        mode: 'autonomous',
+                        isDeploying: false
+                    },
+                    {
+                        id: '4',
+                        name: 'device name that shares common attributes',
+                        lastSeenAt: null,
+                        lastSeenMs: null,
+                        status: 'offline',
+                        mode: 'autonomous',
+                        isDeploying: false
+                    },
+                    {
+                        id: '5',
+                        name: 'device name and common key',
+                        lastSeenAt: null,
+                        lastSeenMs: null,
+                        status: 'offline',
+                        mode: 'autonomous',
+                        isDeploying: false
+                    }
+                ]
+                const instances = []
+
+                cy.intercept(
+                    'GET',
+                    '/api/*/teams/*/applications/status*',
+                    {
+                        count: 1,
+                        applications: [
+                            {
+                                id: '1',
+                                instances,
+                                devices
+                            }
+                        ]
+                    }
+                ).as('getAppStatuses')
+                cy.intercept('get', '/api/*/applications/*/devices*', {
+                    meta: {},
+                    count: 5,
+                    devices
+                })
+                    .as('getDevices')
+                cy.intercept(
+                    'GET',
+                    '/api/*/teams/*/applications*',
+                    {
+                        count: 1,
+                        applications: [
+                            {
+                                id: '1',
+                                name: 'My First App',
+                                description: 'My first empty app description',
+                                instancesSummary: {
+                                    count: 0,
+                                    instances
+                                },
+                                devicesSummary: {
+                                    count: 5,
+                                    devices
+                                }
+                            }
+                        ]
+                    }
+                ).as('getApplications')
+
+                cy.intercept('GET', '/api/*/applications/1', {
+                    id: '1',
+                    name: 'My First App',
+                    description: 'My first empty app description',
+                    team: {
+                        id: 'ateam',
+                        name: 'ateam',
+                        slug: 'ateam'
+                    }
+                }).as('getApplication')
+
+                cy.intercept('GET', '/api/*/applications/1/instances*', {
+                    count: 0,
+                    instances
+                }).as('getApplicationInstances')
+
+                cy.intercept('GET', '/api/*/applications/1/devices*', {
+                    count: 5,
+                    devices
+                }).as('getApplicationDevices')
+
+                cy.home()
+
+                cy.wait('@getAppStatuses')
+                cy.wait('@getApplications')
 
-                // cy.get('[data-el="applications-list"]').children().should('have.length', 3)
-                //
-                // // check that we have three apps after clearing the search input
-                // cy.get('[data-form="search"] input').clear()
-                // cy.get('[data-el="applications-list"]').children().should('have.length', 3)
-                //
-                // // check that we have a single app after searching a term unique to one
-                // cy.get('[data-form="search"] input').type('second')
-                // cy.get('[data-el="applications-list"]').children().should('have.length', 1).contains('My Second App')
+                cy.get('[data-form="search"]').type('common')
+                cy.get('[data-el="has-more-tile"]').click()
+
+                cy.wait('@getApplication')
+                cy.wait('@getApplicationInstances')
+                cy.wait('@getApplicationDevices')
+
+                cy.get('[data-form="search"]').should('exist')
+                cy.get('[data-form="search"] input')
+                    .invoke('val')
+                    .then(val => {
+                        expect(val).to.equal('common')
+                    })
+            })
+
+            it('carries the search queries onwards to the application instances page when clicking show more', () => {
+                const instances = [
+                    {
+                        id: '1',
+                        name: 'common-instance-name',
+                        meta: {
+                            versions: {
+                                launcher: '2.3.1'
+                            },
+                            state: 'running'
+                        },
+                        url: 'https://www.google.com:123/search?q=rick+astley'
+                    },
+                    {
+                        id: '2',
+                        name: 'not-so-common-instance-name',
+                        meta: {
+                            versions: {
+                                launcher: '2.3.1'
+                            },
+                            state: 'running'
+                        },
+                        url: 'https://www.google.com:123/search?q=rick+astley'
+                    },
+                    {
+                        id: '3',
+                        name: 'xyz-instance-name-common-name',
+                        meta: {
+                            versions: {
+                                launcher: '2.3.1'
+                            },
+                            state: 'running'
+                        },
+                        url: 'https://www.google.com:123/search?q=rick+astley'
+                    },
+                    {
+                        id: '4',
+                        name: 'instance-name-that-has-common-el',
+                        meta: {
+                            versions: {
+                                launcher: '2.3.1'
+                            },
+                            state: 'running'
+                        },
+                        url: 'https://www.google.com:123/search?q=rick+astley'
+                    },
+                    {
+                        id: '5',
+                        name: 'another-common-instance-name-that-matches-application-name',
+                        meta: {
+                            versions: {
+                                launcher: '2.3.1'
+                            },
+                            state: 'running'
+                        },
+                        url: 'https://www.google.com:123/search?q=rick+astley'
+                    }
+                ]
+                const devices = []
+                cy.intercept(
+                    'GET',
+                    '/api/*/teams/*/applications/status*',
+                    {
+                        count: 1,
+                        applications: [
+                            {
+                                id: '1',
+                                instances,
+                                devices
+                            }
+                        ]
+                    }
+                ).as('getAppStatuses')
+                cy.intercept('get', '/api/*/applications/*/devices*', {
+                    meta: {},
+                    count: 0,
+                    devices
+                })
+                    .as('getDevices')
+                cy.intercept(
+                    'GET',
+                    '/api/*/teams/*/applications*',
+                    {
+                        count: 1,
+                        applications: [
+                            {
+                                id: '1',
+                                name: 'My First App',
+                                description: 'My first empty app description',
+                                instancesSummary: {
+                                    count: 5,
+                                    instances
+                                },
+                                devicesSummary: {
+                                    count: 0,
+                                    devices
+                                }
+                            }
+                        ]
+                    }
+                ).as('getApplications')
+
+                cy.intercept('GET', '/api/*/applications/1', {
+                    id: '1',
+                    name: 'My First App',
+                    description: 'My first empty app description',
+                    team: {
+                        id: 'ateam',
+                        name: 'ateam',
+                        slug: 'ateam'
+                    }
+                }).as('getApplication')
+
+                cy.intercept('GET', '/api/*/applications/*/instances*', {
+                    count: 5,
+                    instances
+                }).as('getApplicationInstances')
+
+                cy.intercept('GET', '/api/*/applications/*/instances/status', {
+                    count: 5,
+                    instances: []
+                }).as('getSomeStatuses')
+
+                cy.home()
+
+                cy.wait('@getAppStatuses')
+                cy.wait('@getApplications')
+
+                cy.get('[data-form="search"]').type('common')
+                cy.get('[data-el="has-more-tile"]').click()
+
+                cy.wait('@getApplication')
+                cy.wait('@getApplicationInstances')
+                cy.wait('@getSomeStatuses')
+
+                cy.get('[data-form="search"]').should('exist')
+                cy.get('[data-form="search"] input')
+                    .invoke('val')
+                    .then(val => {
+                        expect(val).to.equal('common')
+                    })
             })
         })
     })