Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing statement about environment variables in the pipeline "push to stage" dialog #4603

Open
Steve-Mcl opened this issue Oct 2, 2024 · 0 comments · May be fixed by #4604
Open

Confusing statement about environment variables in the pipeline "push to stage" dialog #4603

Steve-Mcl opened this issue Oct 2, 2024 · 0 comments · May be fixed by #4604
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working needs-triage Needs looking at to decide what to do size:XS - 1 Sizing estimation point

Comments

@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Oct 2, 2024

Current Behavior

In reviewing an article around pipelines, the authors write up regarding how Env Vars are transmitted did not match my expectation of how things operate. I double checked this and found the write up to be incorrect but it was a reasonable interpretation of the dialog we show to users.

image

Last sentence states It will also transfer the keys, but not the values, of any newly created Environment Variables not currently in the target instance.

I checked with the team on slack and unsurprisingly got misunderstanding across the board!

Expected Behavior

clarify the statement.

Something like "The pipeline operation will copy environment variables but it will not overwrite any that exist in the target."

something that describes the visualisation below:

image

Steps To Reproduce

operate a pipeline stage

Environment

  • FlowFuse version: 2.9 - prod/live/staging
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@Steve-Mcl Steve-Mcl added bug Something isn't working needs-triage Needs looking at to decide what to do area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point labels Oct 2, 2024
@Steve-Mcl Steve-Mcl linked a pull request Oct 2, 2024 that will close this issue
10 tasks
@Steve-Mcl Steve-Mcl linked a pull request Oct 2, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working needs-triage Needs looking at to decide what to do size:XS - 1 Sizing estimation point
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant