Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline device stage cannot be edited and looks like it is deploying #5078

Open
Steve-Mcl opened this issue Feb 5, 2025 · 0 comments
Open
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do size:M - 3 Sizing estimation point

Comments

@Steve-Mcl
Copy link
Contributor

Current Behavior

Upon adding a device to a pipeline, i see this:

Image

The issues I see here are:

  1. It is not actually deploying to a 2nd stage (it has just been added) - it just has a newer target snapshot than active snapshot.
    • While working on the device (in dev mode), I have taken snapshots along the way. I DID set the check "set as target" because if I switch out of dev mode I want the latest snapshot to be the running snapshot
  2. I cannot edit/remove this stage

Expected Behavior

The way we determine a pipeline is deploying is not perfect. As far as i remember, we use the snapshot target being different to the actual as the flag for "deploying". That does not mean the first stage of a pipeline is actually being pushed.

We likely need to look at a better means of determining a pipeline has been operated.

Steps To Reproduce

  1. Take a snapshot of a device and set as target
    1. this is because you want the device to be running latest snapshot in the event of switching it out of dev mode
  2. create a new pipeline
  3. set the 1st stage as the device

Environment

  • FlowFuse version: FFC (2.13)
  • Node.js version:
  • npm version:
  • Platform/OS: win 11
  • Browser: Chrome latest

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@Steve-Mcl Steve-Mcl added bug Something isn't working needs-triage Needs looking at to decide what to do size:M - 3 Sizing estimation point labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do size:M - 3 Sizing estimation point
Projects
Status: No status
Development

No branches or pull requests

1 participant