Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block deploy to netlify if docs output is empty #967

Open
knolleary opened this issue Jul 13, 2023 · 1 comment
Open

Block deploy to netlify if docs output is empty #967

knolleary opened this issue Jul 13, 2023 · 1 comment
Labels
priority:high High Priority task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@knolleary
Copy link
Member

knolleary commented Jul 13, 2023 •
edited
Loading

Description

Our build action should fail if, after the build has run, the _site/docs/ directory is empty - otherwise we end up deploying the site without the docs available.

This should be part of the GH Action. It is valid to run a build locally and not include the docs when developing on other parts of the site.

Epic/Story

No response

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate
@knolleary knolleary added task A piece of work that isn't necessarily tied to a specific Epic or Story. priority:high High Priority labels Jul 13, 2023
@Pezmc Pezmc self-assigned this Jul 13, 2023
@Pezmc Pezmc mentioned this issue Jul 13, 2023
Merged
3 tasks
@Pezmc Pezmc removed their assignment Jul 17, 2023
@Pezmc
Copy link
Contributor

Pezmc commented Jul 17, 2023

From #969:

I had a working proof of concept for #967 (464e613) but have reverted it as it causes Netflify PR deploy previews to fail, as they never have the docs/ only builds from the live branch; and I time boxed this to an hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:high High Priority task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knolleary @Pezmc