Skip to content

Unskip & fix skipped tests (Windows I/O, TIFF reshape axes, missing core symbols, 3D shape ambiguity, Torch parity drift, flow mock) #2

@phflot

Description

@phflot

Problem

Multiple tests are currently skipped because they fail deterministically (platform/axis handling/API/parity).

Root causes + fixes

  • Windows temp-file locking: tests pass an open NamedTemporaryFile path to TIFFFileWriter3DPermissionError on remove/overwrite. Fix: use TemporaryDirectory + explicit paths; close all handles before writing.
  • TIFF reshape series axes (TCYX/TZCYX/ZCYX/… ): ReshapeTIFFReader._read_series_mode doesn’t normalize/squeeze/reorder TZ/C/Z dims, producing non-(H,W,C) frames. Fix: enforce per-frame (H,W,C); if Z==1 squeeze; if Z>1 either flatten (T,Z)→time (documented) or raise clear error directing users to TIFFFileReader3D.
  • Core/API gaps + 3D shape ambiguity
    • compensate_inplace expects missing compensate_sequence_uv.
    • compensate_arr_3D turns (Z,Y,X,C) into (1,Z,Y,X,C).
  • CPU and Torch parity drift (normalize/gaussian/resize): differences are algorithmic + dtype policy (Torch forced fp32).
    • Approximate Torch: relax parity tests to property/tolerance checks and document non-bitwise parity.
  • Flow extraction test: code path changed.

Affected tests

tests/cli/test_tiff_reshape.py (reshape suite), CLI integration test_cli_with_all_options, TestConvenienceFunction3D::test_compensate_inplace_3d, test_shape_ambiguity_handling, parity suites for normalize/gaussian/resize, TestFlowComputation3D::test_3d_flow_parameters_extraction.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions