From a0a78110b9f67a6db58719672d788f6eabd50888 Mon Sep 17 00:00:00 2001
From: Joe <joe@fluidnumerics.com>
Date: Tue, 19 Sep 2023 21:01:34 -0400
Subject: [PATCH] Add more version builds

---
 .github/workflows/ci.yml | 28 ++++++++++++++++++++++++++++
 Dockerfile.centos8       |  3 ++-
 Dockerfile.ubuntu2204    |  3 ++-
 README.md                | 12 ++++++++++--
 4 files changed, 42 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index ef7d65a..1b90143 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -12,9 +12,37 @@ jobs:
         fail-fast: false
         matrix:
           include:
+            - rocm_version: '5.3'
+              rocm_package_set: 'rocm-dev'
+              operating_system: 'centos8'
+            
+            - rocm_version: '5.4'
+              rocm_package_set: 'rocm-dev'
+              operating_system: 'centos8'
+            
+            - rocm_version: '5.5'
+              rocm_package_set: 'rocm-dev'
+              operating_system: 'centos8'
+
             - rocm_version: '5.6'
               rocm_package_set: 'rocm-dev'
               operating_system: 'centos8'
+            
+            - rocm_version: '5.7'
+              rocm_package_set: 'rocm-dev'
+              operating_system: 'centos8'
+
+            - rocm_version: '5.3'
+              rocm_package_set: 'rocm-dev'
+              operating_system: 'ubuntu2204'
+            
+            - rocm_version: '5.4'
+              rocm_package_set: 'rocm-dev'
+              operating_system: 'ubuntu2204'
+
+            - rocm_version: '5.5'
+              rocm_package_set: 'rocm-dev'
+              operating_system: 'ubuntu2204'
 
             - rocm_version: '5.6'
               rocm_package_set: 'rocm-dev'
diff --git a/Dockerfile.centos8 b/Dockerfile.centos8
index 450293c..ebed8bd 100644
--- a/Dockerfile.centos8
+++ b/Dockerfile.centos8
@@ -1,6 +1,7 @@
 FROM centos:centos8 as bootstrap
 
 ARG ROCM_VERSION=5.6
+ARG PACKAGE_SET="rocm-dev"
 
 RUN sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \
     sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* &&\
@@ -21,4 +22,4 @@ gpgkey=https://repo.radeon.com/rocm/rocm.gpg.key" > /etc/yum.repos.d/rocm.repo &
 cat /etc/yum.repos.d/rocm.repo &&\
 yum clean all -y &&\
 yum update -y &&\
-yum install -y rocm-dev 
\ No newline at end of file
+yum install -y ${PACKAGE_SET}
\ No newline at end of file
diff --git a/Dockerfile.ubuntu2204 b/Dockerfile.ubuntu2204
index b068667..aa90c7a 100644
--- a/Dockerfile.ubuntu2204
+++ b/Dockerfile.ubuntu2204
@@ -1,6 +1,7 @@
 FROM ubuntu:22.04 as bootstrap
 
 ARG ROCM_VERSION=5.7
+ARG PACKAGE_SET="rocm-dev"
 
 ENV DEBIAN_FRONTEND=noninteractive   \
     LANGUAGE=en_US.UTF-8 \
@@ -29,4 +30,4 @@ RUN mkdir --parents --mode=0755 /etc/apt/keyrings &&\
     echo "Package: *\nPin: release o=repo.radeon.com\nPin-Priority: 600" | \
     tee /etc/apt/preferences.d/rocm-pin-600 && \
     apt-get -y update && \
-    apt-get -y install rocm-dev
\ No newline at end of file
+    apt-get -y install ${PACKAGE_SET}
\ No newline at end of file
diff --git a/README.md b/README.md
index 4dd3d24..57f2491 100644
--- a/README.md
+++ b/README.md
@@ -37,10 +37,18 @@ docker inspect -f "{{ .Size }}" IMAGE
 
 | Operating System | ROCm Version | Package set  | Size      |
 | :--------------: | :----------: | :----------: |:--------: |
-|   ubuntu 22.04   | rocm 5.6     | rocm-dev     | 5.726 GB  |
-|     centos 8     | rocm 5.6     | rocm-dev     | 5.184 GB  |
+|   Ubuntu 22.04   | rocm 5.6     | rocm-dev     | 5.726 GB  |
+|     CentOS 8     | rocm 5.6     | rocm-dev     | 5.184 GB  |
 
+## ROCm versions
+Ok, we lied. Really it took a few minutes of thought to realize where you can find the available versions of ROCm, for each operating system. Essentially, you can peruse the indexes for the yum or apt repositories that are posted by ROCm. Sure would be nice though if this was just in documentation somewhere.
 
+To find the currently available versions of ROCm, see
+
+| Operating System | Index URL                           |
+| :--------------: | :---------------------------------: |
+| Ubuntu 22.04     | https://repo.radeon.com/rocm/apt/   |
+| CentOS 8         | https://repo.radeon.com/rocm/rhel8/ |
 ## ROCm Packages
 
 If you're interested in generating a package list for ROCm, you  can add the following line to your Docker recipe file