Controllers/Modulators not resetting after program change.

[bradholland]

kinda a follow on from my last question, but here goes.

I have opted to setup modulators within my soundfont files, rather than use the fluidsynth modulators.
I have a fluidsynth instance wrapped in an LV2 plugin. the problem is that when I change presets, my cc controls seem to remain, so loading the next preset in the bank will not sound as intended., inheriting the previous cc values.

Any ideas what I am doing wrong here?
thanks

CC_CUTOFF 74
CC_RESONANCE 71
CC_ATTACK 73
CC_DECAY 75
CC_SUSTAIN 70
CC_RELEASE 72

/*
 * Handle program changes with proper bank selection
 */
static void handle_program_change(Plugin* plugin, int program) {
    if (program < 0 || program >= plugin->program_count) {
        fprintf(stderr, "Invalid program number: %d (max: %d)\n", 
                program, plugin->program_count - 1);
        return;
    }

    // Reset all notes and sounds
    fluid_synth_all_notes_off(plugin->synth, -1);
    fluid_synth_all_sounds_off(plugin->synth, -1);

    int bank = plugin->programs[program].bank;
    int prog = plugin->programs[program].prog;

    fprintf(stderr, "Changing to program %d (bank:%d prog:%d)\n", 
            program, bank, prog);

    // Send bank select first
    fluid_synth_bank_select(plugin->synth, 0, bank);
    
    // Then send program change
    int result = fluid_synth_program_change(plugin->synth, 0, prog);
    
    if (result != FLUID_OK) {
        fprintf(stderr, "Failed to change program: bank=%d prog=%d\n", bank, prog);
    }
}

 Process control changes - only send CC if control moved
    if (*plugin->cutoff_port != plugin->prev_cutoff) {
        int cc_value = (int)(*plugin->cutoff_port * 127.0f);
        fluid_synth_cc(plugin->synth, 0, CC_CUTOFF, cc_value);
        plugin->prev_cutoff = *plugin->cutoff_port;
    }

    if (*plugin->resonance_port != plugin->prev_resonance) {
        int cc_value = (int)(*plugin->resonance_port * 127.0f);
        fluid_synth_cc(plugin->synth, 0, CC_RESONANCE, cc_value);
        plugin->prev_resonance = *plugin->resonance_port;
    }

    if (*plugin->attack_port != plugin->prev_attack) {
        int cc_value = (int)(*plugin->attack_port * 127.0f);
        fluid_synth_cc(plugin->synth, 0, CC_ATTACK, cc_value);
        plugin->prev_attack = *plugin->attack_port;
    }

    if (*plugin->decay_port != plugin->prev_decay) {
        int cc_value = (int)(*plugin->decay_port * 127.0f);
        fluid_synth_cc(plugin->synth, 0, CC_DECAY, cc_value);
        plugin->prev_decay = *plugin->decay_port;
    }

    if (*plugin->sustain_port != plugin->prev_sustain) {
        int cc_value = (int)(*plugin->sustain_port * 127.0f);
        fluid_synth_cc(plugin->synth, 0, CC_SUSTAIN, cc_value);
        plugin->prev_sustain = *plugin->sustain_port;
    }

    if (*plugin->release_port != plugin->prev_release) {
        int cc_value = (int)(*plugin->release_port * 127.0f);
        fluid_synth_cc(plugin->synth, 0, CC_RELEASE, cc_value);
        plugin->prev_release = *plugin->release_port;
    }

[derselbst]

Counter question: Why do you think the controllers should reset after sending a program change? According to the MIDI standard, this is not the case. If you want to reset the controller to their default, you need to either send an ResetAllController events (i.e. CC 121) or you need to perform a system reset (fluid_synth_system_reset()).

[bradholland]

You are right, that's dumb of me.
I have tried using the fluid_synth_system_reset() before doing the program change, that seemed to really mess up the next preset for me.

[bradholland]

I got it working.

All along I thought 64 was the default midi cc value. Turns out it wasn't.

Right before I change program I reset values to the following. and now all is good.

// Reset CCs (cutoff to max, others to 0)
fluid_synth_cc(plugin->synth, 0, CC_CUTOFF, 127);    // Cutoff fully open
fluid_synth_cc(plugin->synth, 0, CC_RESONANCE, 0);
fluid_synth_cc(plugin->synth, 0, CC_ATTACK, 0);
fluid_synth_cc(plugin->synth, 0, CC_DECAY, 0);
fluid_synth_cc(plugin->synth, 0, CC_SUSTAIN, 0);
fluid_synth_cc(plugin->synth, 0, CC_RELEASE, 0);

thanks!