You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As title says, the core will crash if a card uses the same granted effect twice in the same chain, but the material giving it is no longer attached to the xyz monster. The crash happens when resolving the the effect the second time, and the crash happens because by that time
the call to get_handler will return nullptr, as the effect will no longer have an active_handler registered. Reproducible with this puzzle.
A similar crash, still caused by the handling of such effects, can occur with cards like Altergeist Multifaker, that use EVENT_CHAINING/EVENT_CHAIN_SOLVED to check the reason effect, by teh time the condition is called, if the xyz monster detached the material giving the effect, re will cause the same crashing behaviour if a function accessing the handler is called. (in the case of multifaker, calling IsActiveType before IsHasType will crash the game, as IsActiveType checks the handler, whereas the other doesn't.)
The text was updated successfully, but these errors were encountered:
As title says, the core will crash if a card uses the same granted effect twice in the same chain, but the material giving it is no longer attached to the xyz monster. The crash happens when resolving the the effect the second time, and the crash happens because by that time
ygopro-core/processor.cpp
Lines 4280 to 4283 in 225a846
the call to get_handler will return nullptr, as the effect will no longer have an active_handler registered.
Reproducible with this puzzle.
A similar crash, still caused by the handling of such effects, can occur with cards like Altergeist Multifaker, that use EVENT_CHAINING/EVENT_CHAIN_SOLVED to check the reason effect, by teh time the condition is called, if the xyz monster detached the material giving the effect,
re
will cause the same crashing behaviour if a function accessing the handler is called. (in the case of multifaker, callingIsActiveType
beforeIsHasType
will crash the game, asIsActiveType
checks the handler, whereas the other doesn't.)The text was updated successfully, but these errors were encountered: