feat: add DSL for easier agent customization #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 new issues
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
...tasource_customizer/lib/forest_admin_datasource_customizer/dsl/helpers/collection_helpers.rb
Show resolved
Hide resolved
...tasource_customizer/lib/forest_admin_datasource_customizer/dsl/helpers/collection_helpers.rb
Show resolved
Hide resolved
...atasource_customizer/lib/forest_admin_datasource_customizer/dsl/context/execution_context.rb
Show resolved
Hide resolved
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
|
Diff Coverage: The code coverage on the diff in this pull request is 97.7%. Total Coverage: This PR will increase coverage by 0.13%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
matthv
force-pushed
the
feat/dsl-customization
branch
from
cc1dd80 to
c9ef24f
Compare
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
matthv
changed the title
matthv
changed the title
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
DayTF
reviewed
Nov 27, 2025
|
|
||
| # Disable search on this collection | ||
| def disable_search | ||
| replace_search { |_query, _context| nil } |
Contributor
There was a problem hiding this comment.
There is a function disable_search, replace with null is false
DayTF
reviewed
Nov 27, 2025
| # end | ||
| # | ||
| # @param block [Proc] search handler | ||
| def enable_search(&block) |
Contributor
There was a problem hiding this comment.
enable_search is not the right naming for this imo, usually search is enabled by default by the DS, you either disable it or replace the search not enable it
DayTF
reviewed
Nov 27, 2025
| # @param key [String] header name | ||
| # @param value [String] header value | ||
| # @return [ExecutionContext] self for chaining | ||
| def set_header(key, value) |
Member
Author
There was a problem hiding this comment.
you are correct, I have removed it
DayTF
reviewed
Nov 27, 2025
| # Add a section/page layout to group fields | ||
| # @param component [String] layout component type | ||
| # @param block [Proc] block containing nested fields | ||
| def section(component: 'Page', &block) |
Contributor
There was a problem hiding this comment.
let's keep the name page as to not confuse the user
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
| # @param headers [Hash] HTTP headers | ||
| # @param body [Hash] request body | ||
| # @return [Hash] the webhook result | ||
| def webhook(url, method: 'POST', headers: {}, body: {}) |
| # @param default [Object] default value | ||
| # @param enum_values [Array] enum values if type is enum | ||
| # @param block [Proc] computation block receiving (records, context) | ||
| def computed_field(name, type:, depends_on: [], default: nil, enum_values: nil, &block) |
| # @param origin_key [String, Symbol] origin key field | ||
| # @param foreign_key [String, Symbol] foreign key field (for many-to-many) | ||
| # @param through [String, Symbol] through collection (for many-to-many) | ||
| def has_many(name, collection: nil, origin_key: nil, foreign_key: nil, through: nil) |
...in_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb
Show resolved
Hide resolved
matthv
force-pushed
the
feat/dsl-customization
branch
from
c41f08c to
6eb5ea8
Compare
| # @param description [String] field description | ||
| # @param placeholder [String] placeholder text | ||
| # @param block [Proc] optional proc for computed values | ||
| def field(name, type:, widget: nil, options: nil, readonly: false, default: nil, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security