Skip to content

fix: prevent error accessing foreign_collection on polymorphic relations #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matthv merged 2 commits into from
Nov 25, 2025
Merged

fix: prevent error accessing foreign_collection on polymorphic relations #211

matthv merged 2 commits into from
Nov 25, 2025

Conversation

@matthv
Copy link
Member

@matthv matthv commented Nov 17, 2025

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@qltysh
Copy link

qltysh bot commented Nov 17, 2025 •
edited
Loading

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will not change total coverage.

File Coverage Changes
Path File Coverage Δ Indirect
packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb 0.0
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@matthv matthv merged commit 3d98753 into main Nov 25, 2025
37 checks passed
@matthv matthv deleted the fix/projection-polymporphic branch November 25, 2025 13:18
forest-bot added a commit that referenced this pull request Nov 25, 2025
@forest-bot
chore(release): 1.14.4 [skip ci]
51c7408 
## [1.14.4](v1.14.3...v1.14.4) (2025-11-25)

### Bug Fixes

* prevent error accessing foreign_collection on polymorphic relations ([#211](#211)) ([3d98753](3d98753))
@forest-bot
Copy link
Member

forest-bot commented Nov 25, 2025

🎉 This PR is included in version 1.14.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DayTF DayTF DayTF approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthv @forest-bot @DayTF