Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb links to Lenses #16

Open
mtessar opened this issue Oct 13, 2022 · 4 comments
Open

Breadcrumb links to Lenses #16

mtessar opened this issue Oct 13, 2022 · 4 comments

Comments

@mtessar
Copy link

mtessar commented Oct 13, 2022

Would it make sense to add a node for the current lens when viewing a lens within a resource to the breadcrumb?

@ianrobertsFF
Copy link
Contributor

Can you elaborate? I'm not sure what you're asking for here.

Do you mean, for example Home -> Your Resource -> Your Lens?

The caveat of that is that currently I don't have a reliable way to then allow for that path to go deeper, IE Home -> Your Resource -> Your Lens -> Resource Record it would instead continue to Home -> Your Resource -> Resource Record upon displaying a record, which is inconsistent from the location the user was previously at, and doesn't offer a direct return path.

I am currently working on allowing for this functionality, but it's not simple, and will require a bit of a rewrite, assuming I can get it working at all (although I'm hoping there should be nothing breaking for current use cases)

@mtessar
Copy link
Author

mtessar commented Oct 14, 2022

Sorry for the lack of clarity. This was exactly what I was thinking about:

Home -> Your Resource -> Your Lens

It totally makes sense that if you went to a record from the lens it would reset the Breadcrumb to Home -> Your Resource -> Resource Record and I can see how that might be a little unclear to the user. It does also make sense a little bit though. I think it's a trade off I would be good with.

Totally makes sense that it's not simple. Thanks for making an awesome package.

@ianrobertsFF
Copy link
Contributor

I'll implement it, but it will be an opt-in via a config entry(globally)/static property, as this will almost certainly be a breaking change when I finish the functionality allowing for a more fluid path of breadcrumbs for things like Dashboards/Lenses

@mtessar
Copy link
Author

mtessar commented Oct 19, 2022

That would be awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants