Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourceBreadcrumbs is not working #42

Open
msucevan opened this issue Mar 12, 2024 · 3 comments
Open

resourceBreadcrumbs is not working #42

msucevan opened this issue Mar 12, 2024 · 3 comments

Comments

@msucevan
Copy link

msucevan commented Mar 12, 2024

Nova version: v4.32.15 (Silver Surfer)

  public function resourceBreadcrumbs(NovaRequest $request, Breadcrumbs $breadcrumbs, array $breadcrumbArray) {
        Log::info('resourceBreadcrumbs' , ['request' => $request, 'breadcrumbs' => $breadcrumbs, 'breadcrumbArray' => $breadcrumbArray]);
        $breadcrumbs->items = [Breadcrumb::make('Home', '/')];
        return $breadcrumbArray;
    }

I even don't get the log, like is never called the function. I'm doing something wrong?

@msucevan
Copy link
Author

    protected function resourceBreadcrumbs(NovaRequest $request, $resource, $breadcrumbArray) {

        if (method_exists($resource, "breadcrumbs")) { //why is just "breadcrumbs" and not "resourceBreadcrumbs" like described in the readme?
            return Arr::wrap($resource->breadcrumbs($request, $this, $breadcrumbArray));
        }

        if (!is_null(static::$resourceBreadcrumbCallback)) {
            return Arr::wrap(call_user_func_array(static::$resourceBreadcrumbCallback, [$request, $this, $breadcrumbArray]));
        }

        return $breadcrumbArray;
    }

@samyouel
Copy link

samyouel commented Aug 23, 2024

Same here... Yeah, if you replace breadcrumbs with resourceBreadcrumbs it seems to work for my use case, but not sure what other implications this has or if this destroys something else?

But in stead of calling

public function resourceBreadcrumbs(NovaRequest $request, Breadcrumbs $breadcrumbs, array $breadcrumbArray)

you can do:

public function breadcrumbs(NovaRequest $request, Breadcrumbs $breadcrumbs, array $breadcrumbArray) 

@msucevan
Copy link
Author

Same here... Yeah, if you replace breadcrumbs with resourceBreadcrumbs it seems to work for my use case, but not sure what other implications this has or if this destroys something else?

But in stead of calling

public function resourceBreadcrumbs(NovaRequest $request, Breadcrumbs $breadcrumbs, array $breadcrumbArray)

you can do:

public function breadcrumbs(NovaRequest $request, Breadcrumbs $breadcrumbs, array $breadcrumbArray) 

Yes is what I did... but as the documentation suggest is to use resourceBreadcrumbs. Anyway looks that this repository is not either maitained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants